AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

fpga manager: xilinx-spi: remove unneeded, mistyped variables

Browse Source 
Using variables does not add readability here: parameters passed
to udelay*() are obviously in microseconds and their meaning is clear
from the context.

The type is also wrong, udelay expects an unsigned long.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
This commit is contained in:
Luca Ceresoli 2020-06-11 23:11:42 +02:00 committed by Moritz Fischer
parent d1ddca78f9
commit 23f872b6ec
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/fpga/xilinx-spi.c
View File

@ -41,8 +41,6 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
const char *buf, size_t count)
{
struct xilinx_spi_conf *conf = mgr->priv;
const size_t prog_latency_7500us = 7500;
const size_t prog_pulse_1us = 1;
if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) {
dev_err(&mgr->dev, "Partial reconfiguration not supported.\n");
@ -51,7 +49,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
gpiod_set_value(conf->prog_b, 1);
udelay(prog_pulse_1us); /* min is 500 ns */
udelay(1); /* min is 500 ns */
gpiod_set_value(conf->prog_b, 0);
@ -61,7 +59,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
}
/* program latency */
usleep_range(prog_latency_7500us, prog_latency_7500us + 100);
usleep_range(7500, 7600);
return 0;
}