AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

selinux: fix return value on error in policydb_read()

Browse Source 
The value of rc is still zero from the last assignment when the error
path is taken. Fix it by setting it to -ENOMEM before the
hashtab_create() call.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e67b2ec9f6 ("selinux: store role transitions in a hash table")
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
This commit is contained in:
Ondrej Mosnacek 2020-05-01 21:51:11 +02:00 committed by Paul Moore
parent 3348bd33e8
commit 46619b44e4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
security/selinux/ss/policydb.c
View File

@ -2540,6 +2540,7 @@ int policydb_read(struct policydb *p, void *fp)
goto bad; goto bad;
nel = le32_to_cpu(buf[0]); nel = le32_to_cpu(buf[0]);
rc = -ENOMEM;
p->role_tr = hashtab_create(role_trans_hash, role_trans_cmp, nel); p->role_tr = hashtab_create(role_trans_hash, role_trans_cmp, nel);
if (!p->role_tr) if (!p->role_tr)
goto bad; goto bad;