AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

drm: Fix hashtab implementation leaking illegal error codes to user space.

Browse Source 
reported by Dave Airlie

Signed-off-by: Dave Airlie <airlied@linux.ie>
This commit is contained in:
Thomas Hellstrom 2006-09-22 04:04:18 +10:00 committed by Dave Airlie
parent 9b1a51b69c
commit 47cc140931
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/char/drm/drm_hashtab.c
View File

@ -106,7 +106,7 @@ int drm_ht_insert_item(drm_open_hash_t *ht, drm_hash_item_t *item)
hlist_for_each(list, h_list) { hlist_for_each(list, h_list) {
entry = hlist_entry(list, drm_hash_item_t, head); entry = hlist_entry(list, drm_hash_item_t, head);
if (entry->key == key) if (entry->key == key)
return -1; return -EINVAL;
if (entry->key > key) if (entry->key > key)
break; break;
parent = list; parent = list;
@ -154,7 +154,7 @@ int drm_ht_find_item(drm_open_hash_t *ht, unsigned long key,
list = drm_ht_find_key(ht, key); list = drm_ht_find_key(ht, key);
if (!list) if (!list)
return -1; return -EINVAL;
*item = hlist_entry(list, drm_hash_item_t, head); *item = hlist_entry(list, drm_hash_item_t, head);
return 0; return 0;
@ -170,7 +170,7 @@ int drm_ht_remove_key(drm_open_hash_t *ht, unsigned long key)
ht->fill--; ht->fill--;
return 0; return 0;
} }
return -1; return -EINVAL;
} }
int drm_ht_remove_item(drm_open_hash_t *ht, drm_hash_item_t *item) int drm_ht_remove_item(drm_open_hash_t *ht, drm_hash_item_t *item)