AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

selinux: fix warning Comparison to bool

Browse Source 
fix below warnings reported by coccicheck

security/selinux/ss/mls.c:539:39-43: WARNING: Comparison to bool
security/selinux/ss/services.c:1815:46-50: WARNING: Comparison to bool
security/selinux/ss/services.c:1827:46-50: WARNING: Comparison to bool

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
This commit is contained in:
Zou Wei 2020-04-14 16:18:07 +08:00 committed by Paul Moore
parent 8f3d9f3542
commit 4b8503967e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
security/selinux/ss/mls.c
View File

@ -536,7 +536,7 @@ int mls_compute_sid(struct policydb *p,
/* Fallthrough */ /* Fallthrough */
case AVTAB_CHANGE: case AVTAB_CHANGE:
if ((tclass == p->process_class) || (sock == true)) if ((tclass == p->process_class) || sock)
/* Use the process MLS attributes. */ /* Use the process MLS attributes. */
return mls_context_cpy(newcontext, scontext); return mls_context_cpy(newcontext, scontext);
else else

4
security/selinux/ss/services.c
View File

@ -1812,7 +1812,7 @@ static int security_compute_sid(struct selinux_state *state,
} else if (cladatum && cladatum->default_role == DEFAULT_TARGET) { } else if (cladatum && cladatum->default_role == DEFAULT_TARGET) {
newcontext.role = tcontext->role; newcontext.role = tcontext->role;
} else { } else {
if ((tclass == policydb->process_class) || (sock == true)) if ((tclass == policydb->process_class) || sock)
newcontext.role = scontext->role; newcontext.role = scontext->role;
else else
newcontext.role = OBJECT_R_VAL; newcontext.role = OBJECT_R_VAL;
@ -1824,7 +1824,7 @@ static int security_compute_sid(struct selinux_state *state,
} else if (cladatum && cladatum->default_type == DEFAULT_TARGET) { } else if (cladatum && cladatum->default_type == DEFAULT_TARGET) {
newcontext.type = tcontext->type; newcontext.type = tcontext->type;
} else { } else {
if ((tclass == policydb->process_class) || (sock == true)) { if ((tclass == policydb->process_class) || sock) {
/* Use the type of process. */ /* Use the type of process. */
newcontext.type = scontext->type; newcontext.type = scontext->type;
} else { } else {