AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

net: ethernet: Fix memleak in ethoc_probe

Browse Source 
[ Upstream commit 5d41f9b7ee7a5a5138894f58846a4ffed601498a ]

When mdiobus_register() fails, priv->mdio allocated
by mdiobus_alloc() has not been freed, which leads
to memleak.

Fixes: e7f4dc3536 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20201223110615.31389-1-dinghao.liu@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dinghao Liu 2020-12-23 19:06:12 +08:00 committed by Greg Kroah-Hartman
parent 2cdf8c2747
commit 7eab4e69cb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/ethoc.c
View File

@ -1211,7 +1211,7 @@ static int ethoc_probe(struct platform_device *pdev)
ret = mdiobus_register(priv->mdio); ret = mdiobus_register(priv->mdio);
if (ret) { if (ret) {
dev_err(&netdev->dev, "failed to register MDIO bus\n"); dev_err(&netdev->dev, "failed to register MDIO bus\n");
goto free2; goto free3;
} }
ret = ethoc_mdio_probe(netdev); ret = ethoc_mdio_probe(netdev);
@ -1243,6 +1243,7 @@ static int ethoc_probe(struct platform_device *pdev)
netif_napi_del(&priv->napi); netif_napi_del(&priv->napi);
error: error:
mdiobus_unregister(priv->mdio); mdiobus_unregister(priv->mdio);
free3:
mdiobus_free(priv->mdio); mdiobus_free(priv->mdio);
free2: free2:
clk_disable_unprepare(priv->clk); clk_disable_unprepare(priv->clk);