forked from luck/tmp_suning_uos_patched
lib: dynamic_debug: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: linux-kernel@vger.kernel.org Acked-by: Jason Baron <jbaron@akamai.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
4a14abc4bb
commit
9fd714cd7f
|
@ -993,20 +993,14 @@ static __initdata int ddebug_init_success;
|
||||||
|
|
||||||
static int __init dynamic_debug_init_debugfs(void)
|
static int __init dynamic_debug_init_debugfs(void)
|
||||||
{
|
{
|
||||||
struct dentry *dir, *file;
|
struct dentry *dir;
|
||||||
|
|
||||||
if (!ddebug_init_success)
|
if (!ddebug_init_success)
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
|
||||||
dir = debugfs_create_dir("dynamic_debug", NULL);
|
dir = debugfs_create_dir("dynamic_debug", NULL);
|
||||||
if (!dir)
|
debugfs_create_file("control", 0644, dir, NULL, &ddebug_proc_fops);
|
||||||
return -ENOMEM;
|
|
||||||
file = debugfs_create_file("control", 0644, dir, NULL,
|
|
||||||
&ddebug_proc_fops);
|
|
||||||
if (!file) {
|
|
||||||
debugfs_remove(dir);
|
|
||||||
return -ENOMEM;
|
|
||||||
}
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user