AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

leds: lm36274: don't iterate through children since there is only one

Browse Source 
Do not use device_for_each_child_node. Since this driver works only with
once child node present, use device_get_next_child_node instead.
This also saves one level of indentation.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Dan Murphy <dmurphy@ti.com>
Tested-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Marek Behún 2020-09-19 20:02:57 +02:00 committed by Pavel Machek
parent d3ab963cf9
commit a448fcf19c
1 changed files with 21 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/leds/leds-lm36274.c
View File

@ -72,30 +72,26 @@ static int lm36274_parse_dt(struct lm36274 *chip)
char label[LED_MAX_NAME_SIZE]; char label[LED_MAX_NAME_SIZE];
struct device *dev = &chip->pdev->dev; struct device *dev = &chip->pdev->dev;
const char *name; const char *name;
int child_cnt; int ret;
int ret = -EINVAL;
/* There should only be 1 node */ /* There should only be 1 node */
child_cnt = device_get_child_node_count(dev); if (device_get_child_node_count(dev) != 1)
if (child_cnt != 1)
return -EINVAL; return -EINVAL;
device_for_each_child_node(dev, child) { child = device_get_next_child_node(dev, NULL);
ret = fwnode_property_read_string(child, "label", &name); ret = fwnode_property_read_string(child, "label", &name);
if (ret) if (ret)
snprintf(label, sizeof(label), "%s::", snprintf(label, sizeof(label), "%s::", chip->pdev->name);
chip->pdev->name);
else else
snprintf(label, sizeof(label), "%s:%s", snprintf(label, sizeof(label), "%s:%s", chip->pdev->name, name);
chip->pdev->name, name);
chip->num_leds = fwnode_property_count_u32(child, "led-sources"); chip->num_leds = fwnode_property_count_u32(child, "led-sources");
if (chip->num_leds <= 0) if (chip->num_leds <= 0)
return -ENODEV; return -ENODEV;
ret = fwnode_property_read_u32_array(child, "led-sources", ret = fwnode_property_read_u32_array(child, "led-sources",
chip->led_sources, chip->led_sources, chip->num_leds);
chip->num_leds);
if (ret) { if (ret) {
dev_err(dev, "led-sources property missing\n"); dev_err(dev, "led-sources property missing\n");
return ret; return ret;
@ -104,7 +100,7 @@ static int lm36274_parse_dt(struct lm36274 *chip)
fwnode_property_read_string(child, "linux,default-trigger", fwnode_property_read_string(child, "linux,default-trigger",
&chip->led_dev.default_trigger); &chip->led_dev.default_trigger);
} fwnode_handle_put(child);
chip->lmu_data.regmap = chip->regmap; chip->lmu_data.regmap = chip->regmap;
chip->lmu_data.max_brightness = MAX_BRIGHTNESS_11BIT; chip->lmu_data.max_brightness = MAX_BRIGHTNESS_11BIT;