AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

UBI: fix dereference after kfree

Browse Source 
Coverity (CID 1614) spotted new_seb being dereferenced after kfree() in
create_vtbl's write_error path.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
This commit is contained in:
Florin Malita 2007-05-03 11:49:57 -04:00 committed by Artem Bityutskiy
parent 341e1a0cf2
commit c4e90ec013
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/mtd/ubi/vtbl.c
View File

@ -317,14 +317,13 @@ static int create_vtbl(const struct ubi_device *ubi, struct ubi_scan_info *si,
return err;
write_error:
kfree(new_seb);
/* May be this physical eraseblock went bad, try to pick another one */
if (++tries <= 5) {
/* Maybe this physical eraseblock went bad, try to pick another one */
if (++tries <= 5)
err = ubi_scan_add_to_list(si, new_seb->pnum, new_seb->ec,
&si->corr);
if (!err)
goto retry;
}
kfree(new_seb);
if (!err)
goto retry;
out_free:
ubi_free_vid_hdr(ubi, vid_hdr);
return err;