forked from luck/tmp_suning_uos_patched
openvswitch: meter: Use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3fcb3f9b68
commit
c5c3899de0
|
@ -206,8 +206,7 @@ static struct dp_meter *dp_meter_create(struct nlattr **a)
|
|||
return ERR_PTR(-EINVAL);
|
||||
|
||||
/* Allocate and set up the meter before locking anything. */
|
||||
meter = kzalloc(n_bands * sizeof(struct dp_meter_band) +
|
||||
sizeof(*meter), GFP_KERNEL);
|
||||
meter = kzalloc(struct_size(meter, bands, n_bands), GFP_KERNEL);
|
||||
if (!meter)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user