AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

sched: Constify function scope static struct sched_param usage

Browse Source 
Function-scope statics are discouraged because they are
easily overlooked and can cause subtle bugs/races due to
their global (non-SMP safe) nature.

Linus noticed that we did this for sched_param - at minimum
make the const.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: Message-ID: <AANLkTinotRxScOHEb0HgFgSpGPkq_6jKTv5CfvnQM=ee@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Peter Zijlstra 2011-01-07 13:41:40 +01:00 committed by Ingo Molnar
parent 524429c31b
commit c9b5f501ef
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/irq/manage.c
View File

@ -577,7 +577,7 @@ irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action) { }
*/ */
static int irq_thread(void *data) static int irq_thread(void *data)
{ {
static struct sched_param param = { static const struct sched_param param = {
.sched_priority = MAX_USER_RT_PRIO/2, .sched_priority = MAX_USER_RT_PRIO/2,
}; };
struct irqaction *action = data; struct irqaction *action = data;

2
kernel/kthread.c
View File

@ -148,7 +148,7 @@ struct task_struct *kthread_create(int (*threadfn)(void *data),
wait_for_completion(&create.done); wait_for_completion(&create.done);
if (!IS_ERR(create.result)) { if (!IS_ERR(create.result)) {
static struct sched_param param = { .sched_priority = 0 }; static const struct sched_param param = { .sched_priority = 0 };
va_list args; va_list args;
va_start(args, namefmt); va_start(args, namefmt);

2
kernel/softirq.c
View File

@ -853,7 +853,7 @@ static int __cpuinit cpu_callback(struct notifier_block *nfb,
cpumask_any(cpu_online_mask)); cpumask_any(cpu_online_mask));
case CPU_DEAD: case CPU_DEAD:
case CPU_DEAD_FROZEN: { case CPU_DEAD_FROZEN: {
static struct sched_param param = { static const struct sched_param param = {
.sched_priority = MAX_RT_PRIO-1 .sched_priority = MAX_RT_PRIO-1
}; };

2
kernel/trace/trace_selftest.c
View File

@ -558,7 +558,7 @@ trace_selftest_startup_nop(struct tracer *trace, struct trace_array *tr)
static int trace_wakeup_test_thread(void *data) static int trace_wakeup_test_thread(void *data)
{ {
/* Make this a RT thread, doesn't need to be too high */ /* Make this a RT thread, doesn't need to be too high */
static struct sched_param param = { .sched_priority = 5 }; static const struct sched_param param = { .sched_priority = 5 };
struct completion *x = data; struct completion *x = data;
sched_setscheduler(current, SCHED_FIFO, &param); sched_setscheduler(current, SCHED_FIFO, &param);