scsi: Use 'depends' with LIBFC instead of 'select'.

LIBFC depends upon SCSI_FC_ATTRS and select's CRC32C.

The only alternative would be to 'select' CRC32C and all of
SCSI_FC_ATTRS direct and indirect dependencies in the Kconfig section
for every LIBFCOE user which makes little sense.

Subsequently, use 'depends' instead of 'select' for LIBFCOE too.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller 2014-09-22 13:14:33 -04:00
parent afbe7af1b2
commit df568d8e52
3 changed files with 6 additions and 6 deletions

View File

@ -592,21 +592,21 @@ config LIBFC
config LIBFCOE config LIBFCOE
tristate "LibFCoE module" tristate "LibFCoE module"
select LIBFC depends on LIBFC
---help--- ---help---
Library for Fibre Channel over Ethernet module Library for Fibre Channel over Ethernet module
config FCOE config FCOE
tristate "FCoE module" tristate "FCoE module"
depends on PCI depends on PCI
select LIBFCOE depends on LIBFCOE
---help--- ---help---
Fibre Channel over Ethernet module Fibre Channel over Ethernet module
config FCOE_FNIC config FCOE_FNIC
tristate "Cisco FNIC Driver" tristate "Cisco FNIC Driver"
depends on PCI && X86 depends on PCI && X86
select LIBFCOE depends on LIBFCOE
help help
This is support for the Cisco PCI-Express FCoE HBA. This is support for the Cisco PCI-Express FCoE HBA.

View File

@ -2,11 +2,11 @@ config SCSI_BNX2X_FCOE
tristate "QLogic NetXtreme II FCoE support" tristate "QLogic NetXtreme II FCoE support"
depends on PCI depends on PCI
depends on (IPV6 || IPV6=n) depends on (IPV6 || IPV6=n)
depends on LIBFC
depends on LIBFCOE
select NETDEVICES select NETDEVICES
select ETHERNET select ETHERNET
select NET_VENDOR_BROADCOM select NET_VENDOR_BROADCOM
select LIBFC
select LIBFCOE
select CNIC select CNIC
---help--- ---help---
This driver supports FCoE offload for the QLogic NetXtreme II This driver supports FCoE offload for the QLogic NetXtreme II

View File

@ -31,7 +31,7 @@ config SCSI_QLA_FC
config TCM_QLA2XXX config TCM_QLA2XXX
tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs" tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
depends on SCSI_QLA_FC && TARGET_CORE depends on SCSI_QLA_FC && TARGET_CORE
select LIBFC depends on LIBFC
select BTREE select BTREE
default n default n
---help--- ---help---