forked from luck/tmp_suning_uos_patched
genirq/timings: Fix error return code in irq_timings_test_irqs()
[ Upstream commit 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b ]
Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.
Fixes: f52da98d90
("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
10d3bdd2d5
commit
e9a902f882
|
@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
|
||||||
|
|
||||||
__irq_timings_store(irq, irqs, ti->intervals[i]);
|
__irq_timings_store(irq, irqs, ti->intervals[i]);
|
||||||
if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
|
if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
|
||||||
|
ret = -EBADSLT;
|
||||||
pr_err("Failed to store in the circular buffer\n");
|
pr_err("Failed to store in the circular buffer\n");
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (irqs->count != ti->count) {
|
if (irqs->count != ti->count) {
|
||||||
|
ret = -ERANGE;
|
||||||
pr_err("Count differs\n");
|
pr_err("Count differs\n");
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue
Block a user