Ido Schimmel 5b8d5429da bridge: netlink: register netdevice before executing changelink ... Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference at 0000000000000190 [13634.939436] IP: __vlan_add+0x73/0x5f0 [...] [13634.939783] Call Trace: [13634.939791] ? pcpu_next_unpop+0x3b/0x50 [13634.939801] ? pcpu_alloc+0x3d2/0x680 [13634.939810] ? br_vlan_add+0x135/0x1b0 [13634.939820] ? __br_vlan_set_default_pvid.part.28+0x204/0x2b0 [13634.939834] ? br_changelink+0x120/0x4e0 [13634.939844] ? br_dev_newlink+0x50/0x70 [13634.939854] ? rtnl_newlink+0x5f5/0x8a0 [13634.939864] ? rtnl_newlink+0x176/0x8a0 [13634.939874] ? mem_cgroup_commit_charge+0x7c/0x4e0 [13634.939886] ? rtnetlink_rcv_msg+0xe1/0x220 [13634.939896] ? lookup_fast+0x52/0x370 [13634.939905] ? rtnl_newlink+0x8a0/0x8a0 [13634.939915] ? netlink_rcv_skb+0xa1/0xc0 [13634.939925] ? rtnetlink_rcv+0x24/0x30 [13634.939934] ? netlink_unicast+0x177/0x220 [13634.939944] ? netlink_sendmsg+0x2fe/0x3b0 [13634.939954] ? _copy_from_user+0x39/0x40 [13634.939964] ? sock_sendmsg+0x30/0x40 [13634.940159] ? ___sys_sendmsg+0x29d/0x2b0 [13634.940326] ? __alloc_pages_nodemask+0xdf/0x230 [13634.940478] ? mem_cgroup_commit_charge+0x7c/0x4e0 [13634.940592] ? mem_cgroup_try_charge+0x76/0x1a0 [13634.940701] ? __handle_mm_fault+0xdb9/0x10b0 [13634.940809] ? __sys_sendmsg+0x51/0x90 [13634.940917] ? entry_SYSCALL_64_fastpath+0x1e/0xad The problem is that the bridge's VLAN group is created after setting the default PVID, when registering the netdevice and executing its ndo_init(). Fix this by changing the order of both operations, so that br_changelink() is only processed after the netdevice is registered, when the VLAN group is already initialized. Fixes: b6677449df ("bridge: netlink: call br_changelink() during br_dev_newlink()") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reported-by: Peter V. Saveliev <peter@svinota.eu> Tested-by: Peter V. Saveliev <peter@svinota.eu> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-04-11 22:22:44 -04:00
..
netfilter	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
br_device.c	bridge: implement missing ndo_uninit()	2017-04-11 22:22:44 -04:00
br_fdb.c	bridge: resolve a false alarm of lockdep	2017-03-16 21:29:20 -07:00
br_forward.c	net: bridge: allow IPv6 when multicast flood is disabled	2017-03-01 20:55:57 -08:00
br_if.c	bridge: implement missing ndo_uninit()	2017-04-11 22:22:44 -04:00
br_input.c	bridge: drop netfilter fake rtable unconditionally	2017-03-13 13:01:10 -07:00
br_ioctl.c	bridge: move to workqueue gc	2017-02-06 22:53:13 -05:00
br_mdb.c	bridge: multicast to unicast	2017-01-24 12:39:52 -05:00
br_multicast.c	bridge: implement missing ndo_uninit()	2017-04-11 22:22:44 -04:00
br_netfilter_hooks.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2017-03-15 15:13:13 -07:00
br_netfilter_ipv6.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
br_netlink_tunnel.c	bridge: vlan tunnel id info range fill size calc cleanups	2017-02-08 14:39:19 -05:00
br_netlink.c	bridge: netlink: register netdevice before executing changelink	2017-04-11 22:22:44 -04:00
br_nf_core.c	net: Remove protocol from struct dst_ops	2015-03-09 16:06:10 -04:00
br_private_stp.h	net: bridge: add helper to set topology change	2016-12-10 21:27:23 -05:00
br_private_tunnel.h	bridge: vlan dst_metadata hooks in ingress and egress paths	2017-02-03 15:21:22 -05:00
br_private.h	bridge: implement missing ndo_uninit()	2017-04-11 22:22:44 -04:00
br_stp_bpdu.c	netfilter: Pass net into okfn	2015-09-17 17:18:37 -07:00
br_stp_if.c	bridge: move to workqueue gc	2017-02-06 22:53:13 -05:00
br_stp_timer.c	bridge: move to workqueue gc	2017-02-06 22:53:13 -05:00
br_stp.c	bridge: move to workqueue gc	2017-02-06 22:53:13 -05:00
br_switchdev.c	bridge: switchdev: Add forward mark support for stacked devices	2016-08-26 13:13:36 -07:00
br_sysfs_br.c	sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h>	2017-03-02 08:42:32 +01:00
br_sysfs_if.c	sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h>	2017-03-02 08:42:32 +01:00
br_vlan_tunnel.c	bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure	2017-02-17 13:33:41 -05:00
br_vlan.c	bridge: Fix error path in nbp_vlan_init	2017-03-01 14:55:28 -08:00
br.c	netfilter: bridge: clarify bridge/netfilter message	2016-10-02 22:44:03 -04:00
Kconfig
Makefile	bridge: per vlan dst_metadata netlink support	2017-02-03 15:21:22 -05:00