Daniel Kurtz dd709e72cb earlycon: Use a pointer table to fix __earlycon_table stride ... Commit 99492c39f3 ("earlycon: Fix __earlycon_table stride") tried to fix __earlycon_table stride by forcing the earlycon_id struct alignment to 32 and asking the linker to 32-byte align the __earlycon_table symbol. This fix was based on commit 07fca0e57f ("tracing: Properly align linker defined symbols") which tried a similar fix for the tracing subsystem. However, this fix doesn't quite work because there is no guarantee that gcc will place structures packed into an array format. In fact, gcc 4.9 chooses to 64-byte align these structs by inserting additional padding between the entries because it has no clue that they are supposed to be in an array. If we are unlucky, the linker will assign symbol "__earlycon_table" to a 32-byte aligned address which does not correspond to the 64-byte aligned contents of section "__earlycon_table". To address this same problem, the fix to the tracing system was subsequently re-implemented using a more robust table of pointers approach by commits: 3d56e331b6 ("tracing: Replace syscall_meta_data struct array with pointer array") 6549864629 ("tracepoints: Fix section alignment using pointer array") e4a9ea5ee7 ("tracing: Replace trace_event struct array with pointer array") Let's use this same "array of pointers to structs" approach for EARLYCON_TABLE. Fixes: 99492c39f3 ("earlycon: Fix __earlycon_table stride") Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> Suggested-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Rob Herring <robh@kernel.org> Tested-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-04-23 10:06:59 +02:00
..
unittest-data	kbuild: mark $(targets) as .SECONDARY and remove .PRECIOUS markers	2018-04-07 19:04:02 +09:00
address.c
base.c
device.c
dynamic.c
fdt_address.c
fdt.c	earlycon: Use a pointer table to fix __earlycon_table stride	2018-04-23 10:06:59 +02:00
irq.c
Kconfig
kobj.c
Makefile
of_mdio.c
of_net.c
of_numa.c
of_private.h
of_reserved_mem.c
overlay.c
pdt.c
platform.c
property.c
resolver.c
unittest.c	proc: add seq_put_decimal_ull_width to speed up /proc/pid/smaps	2018-04-11 10:28:33 -07:00