forked from luck/tmp_suning_uos_patched
d69043c42d
Error handling in xfs_buf_ioapply_map() does not handle IO reference counts correctly. We increment the b_io_remaining count before building the bio, but then fail to decrement it in the failure case. This leads to the buffer never running IO completion and releasing the reference that the IO holds, so at unmount we can leak the buffer. This leak is captured by this assert failure during unmount: XFS: Assertion failed: atomic_read(&pag->pag_ref) == 0, file: fs/xfs/xfs_mount.c, line: 273 This is not a new bug - the b_io_remaining accounting has had this problem for a long, long time - it's just very hard to get a zero length bio being built by this code... Further, the buffer IO error can be overwritten on a multi-segment buffer by subsequent bio completions for partial sections of the buffer. Hence we should only set the buffer error status if the buffer is not already carrying an error status. This ensures that a partial IO error on a multi-segment buffer will not be lost. This part of the problem is a regression, however. cc: <stable@vger.kernel.org> Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Mark Tinguely <tinguely@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| kmem.c | ||
| kmem.h | ||
| Makefile | ||
| mrlock.h | ||
| time.h | ||
| uuid.c | ||
| uuid.h | ||
| xfs_acl.c | ||
| xfs_acl.h | ||
| xfs_ag.h | ||
| xfs_alloc_btree.c | ||
| xfs_alloc_btree.h | ||
| xfs_alloc.c | ||
| xfs_alloc.h | ||
| xfs_aops.c | ||
| xfs_aops.h | ||
| xfs_attr_leaf.c | ||
| xfs_attr_leaf.h | ||
| xfs_attr_sf.h | ||
| xfs_attr.c | ||
| xfs_attr.h | ||
| xfs_bit.c | ||
| xfs_bit.h | ||
| xfs_bmap_btree.c | ||
| xfs_bmap_btree.h | ||
| xfs_bmap.c | ||
| xfs_bmap.h | ||
| xfs_btree.c | ||
| xfs_btree.h | ||
| xfs_buf_item.c | ||
| xfs_buf_item.h | ||
| xfs_buf.c | ||
| xfs_buf.h | ||
| xfs_da_btree.c | ||
| xfs_da_btree.h | ||
| xfs_dfrag.c | ||
| xfs_dfrag.h | ||
| xfs_dinode.h | ||
| xfs_dir2_block.c | ||
| xfs_dir2_data.c | ||
| xfs_dir2_format.h | ||
| xfs_dir2_leaf.c | ||
| xfs_dir2_node.c | ||
| xfs_dir2_priv.h | ||
| xfs_dir2_sf.c | ||
| xfs_dir2.c | ||
| xfs_dir2.h | ||
| xfs_discard.c | ||
| xfs_discard.h | ||
| xfs_dquot_item.c | ||
| xfs_dquot_item.h | ||
| xfs_dquot.c | ||
| xfs_dquot.h | ||
| xfs_error.c | ||
| xfs_error.h | ||
| xfs_export.c | ||
| xfs_export.h | ||
| xfs_extent_busy.c | ||
| xfs_extent_busy.h | ||
| xfs_extfree_item.c | ||
| xfs_extfree_item.h | ||
| xfs_file.c | ||
| xfs_filestream.c | ||
| xfs_filestream.h | ||
| xfs_fs_subr.c | ||
| xfs_fs.h | ||
| xfs_fsops.c | ||
| xfs_fsops.h | ||
| xfs_globals.c | ||
| xfs_ialloc_btree.c | ||
| xfs_ialloc_btree.h | ||
| xfs_ialloc.c | ||
| xfs_ialloc.h | ||
| xfs_iget.c | ||
| xfs_inode_item.c | ||
| xfs_inode_item.h | ||
| xfs_inode.c | ||
| xfs_inode.h | ||
| xfs_inum.h | ||
| xfs_ioctl32.c | ||
| xfs_ioctl32.h | ||
| xfs_ioctl.c | ||
| xfs_ioctl.h | ||
| xfs_iomap.c | ||
| xfs_iomap.h | ||
| xfs_iops.c | ||
| xfs_iops.h | ||
| xfs_itable.c | ||
| xfs_itable.h | ||
| xfs_linux.h | ||
| xfs_log_cil.c | ||
| xfs_log_priv.h | ||
| xfs_log_recover.c | ||
| xfs_log_recover.h | ||
| xfs_log.c | ||
| xfs_log.h | ||
| xfs_message.c | ||
| xfs_message.h | ||
| xfs_mount.c | ||
| xfs_mount.h | ||
| xfs_mru_cache.c | ||
| xfs_mru_cache.h | ||
| xfs_qm_bhv.c | ||
| xfs_qm_syscalls.c | ||
| xfs_qm.c | ||
| xfs_qm.h | ||
| xfs_quota_priv.h | ||
| xfs_quota.h | ||
| xfs_quotaops.c | ||
| xfs_rename.c | ||
| xfs_rtalloc.c | ||
| xfs_rtalloc.h | ||
| xfs_sb.h | ||
| xfs_stats.c | ||
| xfs_stats.h | ||
| xfs_super.c | ||
| xfs_super.h | ||
| xfs_sync.c | ||
| xfs_sync.h | ||
| xfs_sysctl.c | ||
| xfs_sysctl.h | ||
| xfs_trace.c | ||
| xfs_trace.h | ||
| xfs_trans_ail.c | ||
| xfs_trans_buf.c | ||
| xfs_trans_dquot.c | ||
| xfs_trans_extfree.c | ||
| xfs_trans_inode.c | ||
| xfs_trans_priv.h | ||
| xfs_trans_space.h | ||
| xfs_trans.c | ||
| xfs_trans.h | ||
| xfs_types.h | ||
| xfs_utils.c | ||
| xfs_utils.h | ||
| xfs_vnode.h | ||
| xfs_vnodeops.c | ||
| xfs_vnodeops.h | ||
| xfs_xattr.c | ||
| xfs.h | ||