Thomas Gleixner 4673247562 genirq: Deal with desc->set_type() changing desc->chip ... The set_type() function can change the chip implementation when the trigger mode changes. That might result in using an non-initialized irq chip when called from __setup_irq() or when called via set_irq_type() on an already enabled irq. The set_irq_type() function should not be called on an enabled irq, but because we forgot to put a check into it, we have a bunch of users which grew the habit of doing that and it never blew up as the function is serialized via desc->lock against all users of desc->chip and they never hit the non-initialized irq chip issue. The easy fix for the __setup_irq() issue would be to move the irq_chip_set_defaults(desc->chip) call after the trigger setting to make sure that a chip change is covered. But as we have already users, which do the type setting after request_irq(), the safe fix for now is to call irq_chip_set_defaults() from __irq_set_trigger() when desc->set_type() changed the irq chip. It needs a deeper analysis whether we should refuse to change the chip on an already enabled irq, but that'd be a large scale change to fix all the existing users. So that's neither stable nor 2.6.35 material. Reported-by: Esben Haabendal <eha@doredevelopment.dk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: linuxppc-dev <linuxppc-dev@ozlabs.org> Cc: stable@kernel.org		2010-06-09 17:05:08 +02:00
..
autoprobe.c
chip.c
devres.c
handle.c	genirq: Run irq handlers with interrupts disabled	2010-04-13 16:36:40 +02:00
internals.h
Makefile
manage.c	genirq: Deal with desc->set_type() changing desc->chip	2010-06-09 17:05:08 +02:00
migration.c
numa_migrate.c
pm.c
proc.c	genirq: Clear CPU mask in affinity_hint when none is provided	2010-05-12 11:23:34 +02:00
resend.c
spurious.c