Darrick J. Wong 163a203ddb ext4: mark block group as corrupt on block bitmap error ... When we notice a block-bitmap corruption (because of device failure or something else), we should mark this group as corrupt and prevent further block allocations/deallocations from it. Currently, we end up generating one error message for every block in the bitmap. This potentially could make the system unstable as noticed in some bugs. With this patch, the error will be printed only the first time and mark the entire block group as corrupted. This prevents future access allocations/deallocations from it. Also tested by corrupting the block bitmap and forcefully introducing the mb_free_blocks error: (1) create a largefile (2Gb) $ dd if=/dev/zero of=largefile oflag=direct bs=10485760 count=200 (2) umount filesystem. use dumpe2fs to see which block-bitmaps are in use by largefile and note their block numbers (3) use dd to zero-out the used block bitmaps $ dd if=/dev/zero of=/dev/hdc4 bs=4096 seek=14 count=8 oflag=direct (4) mount the FS and delete the largefile. (5) recreate the largefile. verify that the new largefile does not get any blocks from the groups marked as bad. Without the patch, we will see mb_free_blocks error for each bit in each zero'ed out bitmap at (4). With the patch, we only see the error once per blockgroup: [ 309.706803] EXT4-fs error (device sdb4): ext4_mb_generate_buddy:735: group 15: 32768 clusters in bitmap, 0 in gd. blk grp corrupted. [ 309.720824] EXT4-fs error (device sdb4): ext4_mb_generate_buddy:735: group 14: 32768 clusters in bitmap, 0 in gd. blk grp corrupted. [ 309.732858] EXT4-fs error (device sdb4) in ext4_free_blocks:4802: IO failure [ 309.748321] EXT4-fs error (device sdb4): ext4_mb_generate_buddy:735: group 13: 32768 clusters in bitmap, 0 in gd. blk grp corrupted. [ 309.760331] EXT4-fs error (device sdb4) in ext4_free_blocks:4802: IO failure [ 309.769695] EXT4-fs error (device sdb4): ext4_mb_generate_buddy:735: group 12: 32768 clusters in bitmap, 0 in gd. blk grp corrupted. [ 309.781721] EXT4-fs error (device sdb4) in ext4_free_blocks:4802: IO failure [ 309.798166] EXT4-fs error (device sdb4): ext4_mb_generate_buddy:735: group 11: 32768 clusters in bitmap, 0 in gd. blk grp corrupted. [ 309.810184] EXT4-fs error (device sdb4) in ext4_free_blocks:4802: IO failure [ 309.819532] EXT4-fs error (device sdb4): ext4_mb_generate_buddy:735: group 10: 32768 clusters in bitmap, 0 in gd. blk grp corrupted. Google-Bug-Id: 7258357 [darrick.wong@oracle.com] Further modifications (by Darrick) to make more obvious that this corruption bit applies to blocks only. Set the corruption flag if the block group bitmap verification fails. Original-author: Aditya Kali <adityakali@google.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>		2013-08-28 17:35:51 -04:00
..
acl.c
acl.h
balloc.c	ext4: mark block group as corrupt on block bitmap error	2013-08-28 17:35:51 -04:00
bitmap.c
block_validity.c
dir.c	ext4: Fix misspellings using 'codespell' tool	2013-08-28 14:40:12 -04:00
ext4_extents.h	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
ext4_jbd2.c	jbd2: Fix use after free after error in jbd2_journal_dirty_metadata()	2013-08-12 09:53:28 -04:00
ext4_jbd2.h	ext4: Fix misspellings using 'codespell' tool	2013-08-28 14:40:12 -04:00
ext4.h	ext4: mark block group as corrupt on block bitmap error	2013-08-28 17:35:51 -04:00
extents_status.c	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
extents_status.h	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
extents.c	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
file.c	jbd2: Fix oops in jbd2_journal_file_inode()	2013-08-16 21:19:41 -04:00
fsync.c
hash.c
ialloc.c	ext4: avoid reusing recently deleted inodes in no journal mode	2013-08-16 22:06:55 -04:00
indirect.c	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
inline.c
inode.c	ext4: Fix misspellings using 'codespell' tool	2013-08-28 14:40:12 -04:00
ioctl.c	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
Kconfig
Makefile
mballoc.c	ext4: mark block group as corrupt on block bitmap error	2013-08-28 17:35:51 -04:00
mballoc.h
migrate.c	ext4: Fix misspellings using 'codespell' tool	2013-08-28 14:40:12 -04:00
mmp.c
move_extent.c	ext4: cache all of an extent tree's leaf block upon reading	2013-08-16 21:23:41 -04:00
namei.c	ext4: allocate delayed allocation blocks before rename	2013-08-16 22:06:53 -04:00
page-io.c
resize.c
super.c	ext4: fix mount/remount error messages for incompatible mount options	2013-08-08 23:02:24 -04:00
symlink.c
truncate.h
xattr_security.c
xattr_trusted.c
xattr_user.c
xattr.c
xattr.h