AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity
173d3adb6f
kernel_optimize_test/drivers/mfd
History
Brian Norris 11799564fc mfd: cros_ec: Retry commands when EC is known to be busy 
Commit 001dde9400 ("mfd: cros ec: spi: Fix "in progress" error
signaling") pointed out some bad code, but its analysis and conclusion
was not 100% correct.

It *is* correct that we should not propagate result==EC_RES_IN_PROGRESS
for transport errors, because this has a special meaning -- that we
should follow up with EC_CMD_GET_COMMS_STATUS until the EC is no longer
busy. This is definitely the wrong thing for many commands, because
among other problems, EC_CMD_GET_COMMS_STATUS doesn't actually retrieve
any RX data from the EC, so commands that expected some data back will
instead start processing junk.

For such commands, the right answer is to either propagate the error
(and return that error to the caller) or resend the original command
(*not* EC_CMD_GET_COMMS_STATUS).

Unfortunately, commit 001dde9400 forgets a crucial point: that for
some long-running operations, the EC physically cannot respond to
commands any more. For example, with EC_CMD_FLASH_ERASE, the EC may be
re-flashing its own code regions, so it can't respond to SPI interrupts.
Instead, the EC prepares us ahead of time for being busy for a "long"
time, and fills its hardware buffer with EC_SPI_PAST_END. Thus, we
expect to see several "transport" errors (or, messages filled with
EC_SPI_PAST_END). So we should really translate that to a retryable
error (-EAGAIN) and continue sending EC_CMD_GET_COMMS_STATUS until we
get a ready status.

IOW, it is actually important to treat some of these "junk" values as
retryable errors.

Together with commit 001dde9400, this resolves bugs like the
following:

1. EC_CMD_FLASH_ERASE now works again (with commit 001dde9400, we
   would abort the first time we saw EC_SPI_PAST_END)
2. Before commit 001dde9400, transport errors (e.g.,
   EC_SPI_RX_BAD_DATA) seen in other commands (e.g.,
   EC_CMD_RTC_GET_VALUE) used to yield junk data in the RX buffer; they
   will now yield -EAGAIN return values, and tools like 'hwclock' will
   simply fail instead of retrieving and re-programming undefined time
   values

Fixes: 001dde9400 ("mfd: cros ec: spi: Fix "in progress" error signaling")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
2018-05-23 06:59:00 +01:00
..
88pm80x.c
88pm800.c
88pm805.c
88pm860x-core.c
88pm860x-i2c.c
aat2870-core.c
ab3100-core.c
ab3100-otp.c
ab8500-core.c mfd: ab8500-core: Constify attribute_group structures 2017-09-05 08:46:00 +01:00
ab8500-debugfs.c vfs: do bulk POLL* -> EPOLL* replacement 2018-02-11 14:34:03 -08:00
ab8500-gpadc.c
ab8500-sysctrl.c
abx500-core.c
ac100.c
act8945a.c
adp5520.c
altera-a10sr.c mfd: altr_a10sr: Add Arria10 DevKit Reset Controller 2017-04-27 09:25:04 +01:00
arizona-core.c mfd: arizona: Remove audio related device tree code 2017-09-20 17:34:04 +01:00
arizona-i2c.c
arizona-irq.c kernel/irq: Extend lockdep class for request mutex 2017-12-28 12:26:35 +01:00
arizona-spi.c
arizona.h
as3711.c
as3722.c
asic3.c mfd: asic3: Make use of raw_spinlock variants 2017-04-27 09:25:05 +01:00
atmel-flexcom.c atmel_flexcom: Support resuming after a chip reset 2018-01-08 11:03:35 +00:00
atmel-hlcdc.c
atmel-smc.c mfd: syscon: atmel-smc: Add helper to retrieve register layout 2017-09-05 08:46:01 +01:00
axp20x-i2c.c
axp20x-rsb.c mfd: axp20x: Add support for AXP813 PMIC 2017-09-05 08:46:00 +01:00
axp20x.c mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile 2018-01-08 11:03:35 +00:00
bcm590xx.c
bd9571mwv.c mfd: Add ROHM BD9571MWV-M MFD PMIC driver 2017-09-05 08:46:00 +01:00
cros_ec_acpi_gpe.c
cros_ec_dev.c platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle 2018-04-10 22:25:07 -07:00
cros_ec_dev.h cros_ec: Move cros_ec_dev module to drivers/mfd 2017-12-15 10:46:06 +00:00
cros_ec_i2c.c
cros_ec_spi.c mfd: cros_ec: Retry commands when EC is known to be busy 2018-05-23 06:59:00 +01:00
cros_ec.c cros_ec: Split cros_ec_devs module 2017-12-15 10:45:11 +00:00
cs47l24-tables.c
cs5535-mfd.c
da903x.c
da9052-core.c mfd: da9052: Fix manual ADC read after timed out read 2017-09-05 08:46:00 +01:00
da9052-i2c.c
da9052-irq.c
da9052-spi.c mfd: da9052: Constify spi_device_id 2017-09-05 08:46:01 +01:00
da9055-core.c
da9055-i2c.c mfd: da9055: Constify i2c_device_id 2017-09-05 08:46:01 +01:00
da9062-core.c Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model" 2017-08-22 09:03:00 +01:00
da9063-core.c
da9063-i2c.c
da9063-irq.c
da9150-core.c
davinci_voicecodec.c
db8500-prcmu.c mfd: db8500-prcmu: Get rid of cpufreq dependency 2017-08-22 15:49:33 +02:00
dbx500-prcmu-regs.h
dln2.c
dm355evm_msp.c mfd: dm355evm_msp: Move header file out of I2C realm 2017-08-15 08:06:14 +01:00
exynos-lpass.c mfd: exynos: Use devm_of_platform_populate() 2017-07-06 08:29:12 +01:00
ezx-pcap.c
fsl-imx25-tsadc.c mfd: fsl-imx25: Clean up irq settings during removal 2017-10-24 09:12:14 +01:00
hi655x-pmic.c mfd: hi655x: Add the clock cell to provide WiFi and Bluetooth 2017-04-27 11:54:43 +01:00
hi6421-pmic-core.c mfd: hi6421-pmic: Add support for HiSilicon Hi6421v530 2017-09-05 08:46:00 +01:00
htc-i2cpld.c
htc-pasic3.c
intel_msic.c
intel_quark_i2c_gpio.c mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform 2017-07-06 08:29:12 +01:00
intel_soc_pmic_bxtwc.c mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips 2017-06-19 15:45:01 +01:00
intel_soc_pmic_chtdc_ti.c mfd: Add support for Cherry Trail Dollar Cove TI PMIC 2017-10-13 10:42:58 +01:00
intel_soc_pmic_chtwc.c mfd: Add Cherry Trail Whiskey Cove PMIC driver 2017-07-06 08:29:13 +01:00
intel_soc_pmic_core.c mfd: Remove duplicate includes 2018-01-08 11:03:35 +00:00
intel_soc_pmic_core.h mfd: intel_soc_pmic: Export separate mfd-cell configs for BYT and CHT 2017-09-05 08:46:02 +01:00
intel_soc_pmic_crc.c mfd: intel_soc_pmic: Export separate mfd-cell configs for BYT and CHT 2017-09-05 08:46:02 +01:00
intel-lpss-acpi.c mfd: intel-lpss: Remove left over variable 2017-04-27 09:25:04 +01:00
intel-lpss-pci.c mfd: intel-lpss: Add missing PCI ID for Intel Sunrise Point LPSS devices 2017-09-05 08:46:01 +01:00
intel-lpss.c PM / mfd: intel-lpss: Use DPM_FLAG_SMART_SUSPEND 2018-01-10 00:48:25 +01:00
intel-lpss.h PM / mfd: intel-lpss: Push system sleep callbacks to late/early stages 2017-10-05 12:59:54 +02:00
ipaq-micro.c mfd: ipaq-micro: Dump debugging hexdumps 2017-07-06 08:29:11 +01:00
janz-cmodio.c
jz4740-adc.c
Kconfig mfd: pm8xxx: Make elegible for COMPILE_TEST 2018-01-08 11:03:35 +00:00
kempld-core.c mfd: kempld-core: Use resource_size function on resource object 2018-01-08 11:03:34 +00:00
lm3533-core.c
lm3533-ctrlbank.c
lp873x.c
lp3943.c
lp8788-irq.c
lp8788.c
lp87565.c mfd: lp87565: Convert to use devm_mfd_add_devices() 2017-09-05 08:46:01 +01:00
lpc_ich.c mfd: lpc_ich: Do not touch SPI-NOR write protection bit on Apollo Lake 2018-01-08 11:03:35 +00:00
lpc_sch.c
Makefile Immutable branch for both MFD and EXTCON tree. 2018-01-08 11:02:37 +00:00
max8907.c
max8925-core.c
max8925-i2c.c mfd: max8925-i2c: Drop unnecessary static 2017-09-05 08:46:00 +01:00
max8997-irq.c
max8997.c
max8998-irq.c
max8998.c mfd: max8998: Fix potential NULL pointer dereference 2017-09-05 08:46:00 +01:00
max14577.c
max77620.c
max77686.c
max77693.c mfd: max77693: Add muic of_compatible in mfd_cell 2017-10-13 10:42:58 +01:00
max77843.c mfd: Remove duplicate includes 2018-01-08 11:03:35 +00:00
mc13xxx-core.c
mc13xxx-i2c.c
mc13xxx-spi.c
mc13xxx.h
mcp-core.c
mcp-sa11x0.c
menelaus.c mfd: menelaus: Remove obsolete local_irq_disable() and local_irq_enable() 2017-04-27 11:54:46 +01:00
menf21bmc.c
mfd-core.c
motorola-cpcap.c mfd: motorola-cpcap: Use devm_of_platform_populate() 2017-07-06 08:29:12 +01:00
mt6397-core.c mfd: mt6397: Align the placement at which the mfd_cell of LED is defined 2017-04-27 09:25:05 +01:00
mxs-lradc.c mfd: mxs-lradc: Fix error handling in mxs_lradc_probe() 2017-10-24 09:12:14 +01:00
omap-usb-host.c
omap-usb-tll.c mfd: omap-usb-tll: Fix register offsets 2017-09-05 08:46:02 +01:00
omap-usb.h
palmas.c mfd: palmas: Assign the right powerhold mask for tps65917 2018-01-08 11:03:34 +00:00
pcf50633-adc.c
pcf50633-core.c mfd: pcf50633: Fix spelling mistake: 'Falied' -> 'Failed' 2018-01-08 11:03:34 +00:00
pcf50633-gpio.c
pcf50633-irq.c
qcom_rpm.c
qcom-pm8xxx.c
qcom-spmi-pmic.c mfd: qcom-spmi-pmic: Use devm_of_platform_populate() 2017-07-06 08:29:12 +01:00
rave-sp.c mfd: Add driver for RAVE Supervisory Processor 2018-01-08 10:08:35 +00:00
rc5t583-irq.c
rc5t583.c
rdc321x-southbridge.c
retu-mfd.c mfd: retu: Add OF device ID table 2017-07-18 08:27:18 +01:00
rk808.c mfd: rk808: Add RK805 power key support 2017-08-21 08:54:56 +01:00
rn5t618.c mfd: rn5t618: Unregister restart handler on remove 2017-07-06 08:29:11 +01:00
rt5033.c
sec-core.c
sec-irq.c
si476x-cmd.c
si476x-i2c.c
si476x-prop.c
sky81452.c
sm501.c i2c: gpio: Augment all boardfiles to use open drain 2017-10-30 08:42:43 +01:00
smsc-ece1099.c mfd: smsc-ece: Use devm_of_platform_populate() 2017-07-06 08:29:12 +01:00
sprd-sc27xx-spi.c mfd: Add Spreadtrum SC27xx series PMICs driver 2017-11-01 09:32:54 +00:00
ssbi.c mfd: ssbi: Use devm_of_platform_populate() 2017-11-01 09:32:23 +00:00
sta2x11-mfd.c mfd: Convert remaining uses of pr_warning to pr_warn 2017-04-27 09:25:05 +01:00
stm32-lptimer.c mfd: stm32: Adopt SPDX identifier 2018-01-08 11:03:35 +00:00
stm32-timers.c mfd: stm32: Adopt SPDX identifier 2018-01-08 11:03:35 +00:00
stmpe-i2c.c
stmpe-spi.c
stmpe.c mfd: stmpe: Fix bit clearing on STMPE1600 2017-04-27 09:25:07 +01:00
stmpe.h
stw481x.c mfd: stw481x: Make three arrays static const, reduces object code size 2017-10-13 10:42:58 +01:00
sun4i-gpadc.c
sun6i-prcm.c
syscon.c mfd: syscon: Add hardware spinlock support 2018-01-12 18:32:55 +00:00
t7l66xb.c mfd: t7l66xb: Handle return value of clk_prepare_enable 2017-09-05 08:46:01 +01:00
tc3589x.c
tc6387xb.c
tc6393xb.c mfd: tc6393xb: Handle return value of clk_prepare_enable 2017-07-06 08:29:12 +01:00
ti_am335x_tscadc.c mfd: ti_am335x_tscadc: Remove redundant assignment to node 2018-01-08 11:03:34 +00:00
ti-lmu.c mfd: Add TI LMU driver 2017-04-27 09:25:04 +01:00
timberdale.c Input: tsc2007 - move header file out of I2C realm 2017-05-22 17:26:58 -07:00
timberdale.h
tmio_core.c mfd: tmio: Move register macros to tmio_core.c 2018-01-08 11:03:34 +00:00
tps6105x.c mfd: tps6105x: Add OF device ID table 2017-07-18 08:27:37 +01:00
tps6507x.c
tps6586x.c
tps65010.c mfd: tps65010: Move header file out of I2C realm 2017-08-15 08:27:22 +01:00
tps65086.c
tps65090.c
tps65217.c mfd: tps65217: Introduce dependency on CONFIG_OF 2017-10-13 10:42:58 +01:00
tps65218.c mfd: tps65218: Introduce dependency on CONFIG_OF 2017-10-13 10:42:59 +01:00
tps65910.c regulator: tps65910: wire up sleep control configuration 2017-06-15 18:23:27 +01:00
tps65911-comparator.c
tps65912-core.c
tps65912-i2c.c
tps65912-spi.c mfd: tps65912: Fix variable name for SPI remove 2017-04-27 09:25:04 +01:00
tps68470.c mfd: Add support for TPS68470 device 2017-09-05 08:46:01 +01:00
tps80031.c
twl-core.c mfd: twl-core: Improve the documentation 2017-09-05 08:45:59 +01:00
twl-core.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
twl4030-audio.c mfd: twl4030-audio: Fix sibling-node lookup 2017-11-29 16:28:45 +00:00
twl4030-irq.c mfd: twl: Move header file out of I2C realm 2017-09-04 14:41:02 +01:00
twl4030-power.c mfd: twl: Move header file out of I2C realm 2017-09-04 14:41:02 +01:00
twl6030-irq.c mfd: twl: Move header file out of I2C realm 2017-09-04 14:41:02 +01:00
twl6040.c mfd: twl6040: Fix child-node lookup 2017-11-29 16:29:36 +00:00
ucb1x00-assabet.c
ucb1x00-core.c
ucb1x00-ts.c
ucb1400_core.c
vexpress-sysreg.c
viperboard.c
vx855.c
wl1273-core.c
wm97xx-core.c mfd: wm97xx-core: core support for wm97xx Codec 2017-09-19 17:07:24 +01:00
wm831x-auxadc.c
wm831x-core.c mfd: wm831x: Remove redundant !pdata checks 2017-07-06 08:29:11 +01:00
wm831x-i2c.c mfd: wm831x-i2c: Add NULL check before pointer dereference 2017-07-06 08:29:11 +01:00
wm831x-irq.c
wm831x-otp.c
wm831x-spi.c mfd: wm831x-spi: Add NULL check before pointer dereference 2017-07-06 08:29:11 +01:00
wm5102-tables.c
wm5110-tables.c
wm8350-core.c
wm8350-gpio.c
wm8350-i2c.c
wm8350-irq.c
wm8350-regmap.c
wm8400-core.c
wm8994-core.c
wm8994-irq.c
wm8994-regmap.c
wm8994.h
wm8997-tables.c
wm8998-tables.c