forked from luck/tmp_suning_uos_patched
259a41d9ae
There are several problems with regards to the return of FE_SET_PROPERTY. The original idea were to return per-property return codes via tvp->result field, and to return an updated set of values. However, that never worked. What's actually implemented is: - the FE_SET_PROPERTY implementation doesn't call .get_frontend callback in order to get the actual parameters after return; - the tvp->result field is only filled if there's no error. So, it is always filled with zero; - FE_SET_PROPERTY doesn't call memdup_user() nor any other copy_to_user() function. So, any changes to the properties will be lost; - FE_SET_PROPERTY is declared as a write-only ioctl (IOW). While we could fix the above, it could cause regressions. So, let's just assume what the code really does, updating the documentation accordingly and removing the logic that would update the discarded tvp->result. Reviewed-by: Shuah Khan <shuahkh@osg.samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> |
||
|---|---|---|
| .. | ||
| cec-drivers | ||
| dvb-drivers | ||
| kapi | ||
| uapi | ||
| v4l-drivers | ||
| .gitignore | ||
| audio.h.rst.exceptions | ||
| ca.h.rst.exceptions | ||
| cec.h.rst.exceptions | ||
| conf_nitpick.py | ||
| conf.py | ||
| dmx.h.rst.exceptions | ||
| frontend.h.rst.exceptions | ||
| index.rst | ||
| intro.rst | ||
| lirc.h.rst.exceptions | ||
| Makefile | ||
| media_kapi.rst | ||
| media_uapi.rst | ||
| media.h.rst.exceptions | ||
| net.h.rst.exceptions | ||
| typical_media_device.svg | ||
| video.h.rst.exceptions | ||
| videodev2.h.rst.exceptions | ||
