Linus Torvalds a32e236eb9 Partially revert "block: fail op_is_write() requests to read-only partitions" ... It turns out that commit 721c7fc701 ("block: fail op_is_write() requests to read-only partitions"), while obviously correct, causes problems for some older lvm2 installations. The reason is that the lvm snapshotting will continue to write to the snapshow COW volume, even after the volume has been marked read-only. End result: snapshot failure. This has actually been fixed in newer version of the lvm2 tool, but the old tools still exist, and the breakage was reported both in the kernel bugzilla and in the Debian bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200439 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900442 The lvm2 fix is here https://sourceware.org/git/?p=lvm2.git;a=commit;h=a6fdb9d9d70f51c49ad11a87ab4243344e6701a3 but until everybody has updated to recent versions, we'll have to weaken the "never write to read-only partitions" check. It now allows the write to happen, but causes a warning, something like this: generic_make_request: Trying to write to read-only block-device dm-3 (partno X) Modules linked in: nf_tables xt_cgroup xt_owner kvm_intel iwlmvm kvm irqbypass iwlwifi CPU: 1 PID: 77 Comm: kworker/1:1 Not tainted 4.17.9-gentoo #3 Hardware name: LENOVO 20B6A019RT/20B6A019RT, BIOS GJET91WW (2.41 ) 09/21/2016 Workqueue: ksnaphd do_metadata RIP: 0010:generic_make_request_checks+0x4ac/0x600 ... Call Trace: generic_make_request+0x64/0x400 submit_bio+0x6c/0x140 dispatch_io+0x287/0x430 sync_io+0xc3/0x120 dm_io+0x1f8/0x220 do_metadata+0x1d/0x30 process_one_work+0x1b9/0x3e0 worker_thread+0x2b/0x3c0 kthread+0x113/0x130 ret_from_fork+0x35/0x40 Note that this is a "revert" in behavior only. I'm leaving alone the actual code cleanups in commit 721c7fc701, but letting the previously uncaught request go through with a warning instead of stopping it. Fixes: 721c7fc701 ("block: fail op_is_write() requests to read-only partitions") Reported-and-tested-by: WGH <wgh@torlan.ru> Acked-by: Mike Snitzer <snitzer@redhat.com> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Ilya Dryomov <idryomov@gmail.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Zdenek Kabelac <zkabelac@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-08-04 18:19:55 -07:00
..
partitions	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
badblocks.c
bfq-cgroup.c
bfq-iosched.c
bfq-iosched.h
bfq-wf2q.c
bio-integrity.c
bio.c	for-linus-20180727	2018-07-27 12:51:00 -07:00
blk-cgroup.c
blk-core.c	Partially revert "block: fail op_is_write() requests to read-only partitions"	2018-08-04 18:19:55 -07:00
blk-exec.c
blk-flush.c
blk-integrity.c
blk-ioc.c
blk-lib.c
blk-map.c
blk-merge.c
blk-mq-cpumap.c
blk-mq-debugfs.c	blk-mq-debugfs: Off by one in blk_mq_rq_state_name()	2018-06-20 11:26:04 -06:00
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c
blk-mq-sched.h
blk-mq-sysfs.c
blk-mq-tag.c	blk-mq: fix blk_mq_tagset_busy_iter	2018-08-02 14:47:20 -06:00
blk-mq-tag.h
blk-mq-virtio.c
blk-mq.c	for-linus-20180727	2018-07-27 12:51:00 -07:00
blk-mq.h
blk-settings.c
blk-softirq.c	block: fix timeout changes for legacy request drivers	2018-06-19 11:27:18 -06:00
blk-stat.c
blk-stat.h
blk-sysfs.c
blk-tag.c	for-linus-20180616	2018-06-17 05:37:55 +09:00
blk-throttle.c
blk-timeout.c	blk-mq: Fix timeout handling in case the timeout handler returns BLK_EH_DONE	2018-06-23 10:25:45 -06:00
blk-wbt.c
blk-wbt.h
blk-zoned.c	treewide: kvmalloc() -> kvmalloc_array()	2018-06-12 16:19:22 -07:00
blk.h
bounce.c
bsg-lib.c
bsg.c	bsg: fix bogus EINVAL on non-data commands	2018-07-11 08:48:28 -06:00
cfq-iosched.c
cmdline-parser.c
compat_ioctl.c
deadline-iosched.c
elevator.c
genhd.c
ioctl.c
ioprio.c
Kconfig	docs: Fix some broken references	2018-06-15 18:10:01 -03:00
Kconfig.iosched
kyber-iosched.c
Makefile
mq-deadline.c
noop-iosched.c
opal_proto.h
partition-generic.c
scsi_ioctl.c
sed-opal.c	block: sed-opal: Fix a couple off by one bugs	2018-06-20 12:04:06 -06:00
t10-pi.c