Xie Yongji 39a70732eb virtio-blk: Use blk_validate_block_size() to validate block size ... commit 57a13a5b8157d9a8606490aaa1b805bafe6c37e1 upstream. The block layer can't support a block size larger than page size yet. And a block size that's too small or not a power of two won't work either. If a misconfigured device presents an invalid block size in configuration space, it will result in the kernel crash something like below: [ 506.154324] BUG: kernel NULL pointer dereference, address: 0000000000000008 [ 506.160416] RIP: 0010:create_empty_buffers+0x24/0x100 [ 506.174302] Call Trace: [ 506.174651] create_page_buffers+0x4d/0x60 [ 506.175207] block_read_full_page+0x50/0x380 [ 506.175798] ? __mod_lruvec_page_state+0x60/0xa0 [ 506.176412] ? __add_to_page_cache_locked+0x1b2/0x390 [ 506.177085] ? blkdev_direct_IO+0x4a0/0x4a0 [ 506.177644] ? scan_shadow_nodes+0x30/0x30 [ 506.178206] ? lru_cache_add+0x42/0x60 [ 506.178716] do_read_cache_page+0x695/0x740 [ 506.179278] ? read_part_sector+0xe0/0xe0 [ 506.179821] read_part_sector+0x36/0xe0 [ 506.180337] adfspart_check_ICS+0x32/0x320 [ 506.180890] ? snprintf+0x45/0x70 [ 506.181350] ? read_part_sector+0xe0/0xe0 [ 506.181906] bdev_disk_changed+0x229/0x5c0 [ 506.182483] blkdev_get_whole+0x6d/0x90 [ 506.183013] blkdev_get_by_dev+0x122/0x2d0 [ 506.183562] device_add_disk+0x39e/0x3c0 [ 506.184472] virtblk_probe+0x3f8/0x79b [virtio_blk] [ 506.185461] virtio_dev_probe+0x15e/0x1d0 [virtio] So let's use a block layer helper to validate the block size. Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Link: https://lore.kernel.org/r/20211026144015.188-5-xieyongji@bytedance.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-04-08 14:39:48 +02:00
..
aoe
drbd	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
mtip32xx
paride
rnbd	block/rnbd-clt: Check the return value of the function rtrs_clt_query	2021-05-19 10:13:06 +02:00
rsxx	block: rsxx: fix error return code of rsxx_pci_probe()	2021-03-17 17:06:33 +01:00
xen-blkback	xen-blkback: fix compatibility bug with single page rings	2021-05-14 09:50:21 +02:00
zram	zram: off by one in read_block_state()	2021-11-18 14:04:27 +01:00
amiflop.c
ataflop.c
brd.c
cryptoloop.c	cryptoloop: add a deprecation warning	2021-09-08 08:49:01 +02:00
floppy.c	floppy: Add max size check for user space request	2022-01-27 10:54:14 +01:00
Kconfig	cryptoloop: add a deprecation warning	2021-09-08 08:49:01 +02:00
loop.c	loop: Use blk_validate_block_size() to validate block size	2021-11-21 13:46:35 +01:00
loop.h
Makefile
nbd.c	Revert "block: nbd: add sanity check for first_minor"	2021-09-16 12:51:23 +02:00
null_blk_main.c	null_blk: fix command timeout completion handling	2021-04-16 11:43:21 +02:00
null_blk_trace.c
null_blk_trace.h
null_blk_zoned.c	drivers/block/null_blk/main: Fix a double free in null_init.	2021-05-14 09:50:28 +02:00
null_blk.h	null_blk: fix command timeout completion handling	2021-04-16 11:43:21 +02:00
pktcdvd.c
ps3disk.c
ps3vram.c
rbd_types.h
rbd.c	rbd: always kick acquire on "acquired" and "released" notifications	2021-07-28 14:35:46 +02:00
skd_main.c	skd_main: remove unused including <linux/version.h>	2020-10-17 08:11:14 -06:00
skd_s1120.h
sunvdc.c
swim_asm.S
swim.c
swim3.c
sx8.c
umem.c	umem: fix error return code in mm_pci_probe()	2021-03-30 14:31:50 +02:00
umem.h
virtio_blk.c	virtio-blk: Use blk_validate_block_size() to validate block size	2022-04-08 14:39:48 +02:00
xen-blkfront.c	xen/blkfront: don't use gnttab_query_foreign_access() for mapped status	2022-03-11 12:11:54 +01:00
xsysace.c	xsysace: use platform_get_resource() and platform_get_irq_optional()	2020-10-29 08:22:33 -06:00
z2ram.c