Vamshi K Sthambamkadi 3aa8fdc37d tracing/probe: Fix memleak in fetch_op_data operations ... kmemleak report: [<57dcc2ca>] __kmalloc_track_caller+0x139/0x2b0 [<f1c45d0f>] kstrndup+0x37/0x80 [<f9761eb0>] parse_probe_arg.isra.7+0x3cc/0x630 [<055bf2ba>] traceprobe_parse_probe_arg+0x2f5/0x810 [<655a7766>] trace_kprobe_create+0x2ca/0x950 [<4fc6a02a>] create_or_delete_trace_kprobe+0xf/0x30 [<6d1c8a52>] trace_run_command+0x67/0x80 [<be812cc0>] trace_parse_run_command+0xa7/0x140 [<aecfe401>] probes_write+0x10/0x20 [<2027641c>] __vfs_write+0x30/0x1e0 [<6a4aeee1>] vfs_write+0x96/0x1b0 [<3517fb7d>] ksys_write+0x53/0xc0 [<dad91db7>] __ia32_sys_write+0x15/0x20 [<da347f64>] do_syscall_32_irqs_on+0x3d/0x260 [<fd0b7e7d>] do_fast_syscall_32+0x39/0xb0 [<ea5ae810>] entry_SYSENTER_32+0xaf/0x102 Post parse_probe_arg(), the FETCH_OP_DATA operation type is overwritten to FETCH_OP_ST_STRING, as a result memory is never freed since traceprobe_free_probe_arg() iterates only over SYMBOL and DATA op types Setup fetch string operation correctly after fetch_op_data operation. Link: https://lkml.kernel.org/r/20200615143034.GA1734@cosmos Cc: stable@vger.kernel.org Fixes: a42e3c4de9 ("tracing/probe: Add immediate string parameter support") Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>		2020-06-16 21:21:02 -04:00
..
blktrace.c	blktrace: fix endianness for blk_log_remap()	2020-06-04 21:23:38 -06:00
bpf_trace.c	maccess: always use strict semantics for probe_kernel_read	2020-06-09 09:39:15 -07:00
fgraph.c
ftrace_internal.h
ftrace.c	Tracing updates for 5.8:	2020-06-09 10:06:18 -07:00
Kconfig	Tracing updates for 5.8:	2020-06-09 10:06:18 -07:00
kprobe_event_gen_test.c
Makefile	Rebase locking/kcsan to locking/urgent	2020-06-11 20:02:46 +02:00
power-traces.c
preemptirq_delay_test.c
ring_buffer_benchmark.c
ring_buffer.c
rpm-traces.c
synth_event_gen_test.c
trace_benchmark.c
trace_benchmark.h
trace_boot.c
trace_branch.c
trace_clock.c
trace_dynevent.c
trace_dynevent.h
trace_entries.h	tracing: Make ftrace packed events have align of 1	2020-06-16 21:21:02 -04:00
trace_event_perf.c
trace_events_filter_test.h
trace_events_filter.c
trace_events_hist.c	tracing: Move synthetic events to a separate file	2020-06-01 08:23:22 -04:00
trace_events_inject.c
trace_events_synth.c	tracing: Move synthetic events to a separate file	2020-06-01 08:23:22 -04:00
trace_events_trigger.c
trace_events.c	tracing: Add hist_debug trace event files for histogram debugging	2020-06-01 08:22:30 -04:00
trace_export.c	tracing: Make ftrace packed events have align of 1	2020-06-16 21:21:02 -04:00
trace_functions_graph.c
trace_functions.c	trace: Fix typo in allocate_ftrace_ops()'s comment	2020-06-16 21:21:02 -04:00
trace_hwlat.c
trace_irqsoff.c
trace_kdb.c
trace_kprobe_selftest.c
trace_kprobe_selftest.h
trace_kprobe.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-06-13 16:27:13 -07:00
trace_mmiotrace.c
trace_nop.c
trace_output.c	mmap locking API: use coccinelle to convert mmap_sem rwsem call sites	2020-06-09 09:39:14 -07:00
trace_output.h
trace_preemptirq.c	x86/entry: Rename trace_hardirqs_off_prepare()	2020-06-11 15:15:24 +02:00
trace_printk.c
trace_probe_tmpl.h
trace_probe.c	tracing/probe: Fix memleak in fetch_op_data operations	2020-06-16 21:21:02 -04:00
trace_probe.h
trace_sched_switch.c
trace_sched_wakeup.c
trace_selftest_dynamic.c
trace_selftest.c
trace_seq.c
trace_stack.c	trace: fix an incorrect __user annotation on stack_trace_sysctl	2020-06-08 10:13:56 -04:00
trace_stat.c
trace_stat.h
trace_synth.h	tracing: Move synthetic events to a separate file	2020-06-01 08:23:22 -04:00
trace_syscalls.c
trace_uprobe.c	tracing/probe: Fix bpf_task_fd_query() for kprobes and uprobes	2020-06-09 11:10:12 -07:00
trace.c	Tracing updates for 5.8:	2020-06-09 10:06:18 -07:00
trace.h	tracing: Make ftrace packed events have align of 1	2020-06-16 21:21:02 -04:00
tracing_map.c
tracing_map.h