forked from luck/tmp_suning_uos_patched
423d856a4d
End result is the same, its an ABI, so the struct won't change, avoid
using a GNU extension, so that we can catch other cases that may be bugs.
Caught when building with clang:
tests/parse-no-sample-id-all.c:53:20: error: field 'attr' with variable sized type 'struct attr_event' not at the end of a struct or class is a GNU extension
[-Werror,-Wgnu-variable-sized-type-not-at-end]
struct attr_event attr;
^
1 error generated.
Testing it:
# perf test sample_id
24: Parse with no sample_id_all bit set : Ok
#
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-e2vs1x771fc208uvxnwcf08b@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
106 lines
2.3 KiB
C
106 lines
2.3 KiB
C
#include <linux/types.h>
|
|
#include <stddef.h>
|
|
|
|
#include "tests.h"
|
|
|
|
#include "event.h"
|
|
#include "evlist.h"
|
|
#include "header.h"
|
|
#include "util.h"
|
|
#include "debug.h"
|
|
|
|
static int process_event(struct perf_evlist **pevlist, union perf_event *event)
|
|
{
|
|
struct perf_sample sample;
|
|
|
|
if (event->header.type == PERF_RECORD_HEADER_ATTR) {
|
|
if (perf_event__process_attr(NULL, event, pevlist)) {
|
|
pr_debug("perf_event__process_attr failed\n");
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
if (event->header.type >= PERF_RECORD_USER_TYPE_START)
|
|
return -1;
|
|
|
|
if (!*pevlist)
|
|
return -1;
|
|
|
|
if (perf_evlist__parse_sample(*pevlist, event, &sample)) {
|
|
pr_debug("perf_evlist__parse_sample failed\n");
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int process_events(union perf_event **events, size_t count)
|
|
{
|
|
struct perf_evlist *evlist = NULL;
|
|
int err = 0;
|
|
size_t i;
|
|
|
|
for (i = 0; i < count && !err; i++)
|
|
err = process_event(&evlist, events[i]);
|
|
|
|
perf_evlist__delete(evlist);
|
|
|
|
return err;
|
|
}
|
|
|
|
struct test_attr_event {
|
|
struct perf_event_header header;
|
|
struct perf_event_attr attr;
|
|
u64 id;
|
|
};
|
|
|
|
/**
|
|
* test__parse_no_sample_id_all - test parsing with no sample_id_all bit set.
|
|
*
|
|
* This function tests parsing data produced on kernel's that do not support the
|
|
* sample_id_all bit. Without the sample_id_all bit, non-sample events (such as
|
|
* mmap events) do not have an id sample appended, and consequently logic
|
|
* designed to determine the id will not work. That case happens when there is
|
|
* more than one selected event, so this test processes three events: 2
|
|
* attributes representing the selected events and one mmap event.
|
|
*
|
|
* Return: %0 on success, %-1 if the test fails.
|
|
*/
|
|
int test__parse_no_sample_id_all(int subtest __maybe_unused)
|
|
{
|
|
int err;
|
|
|
|
struct test_attr_event event1 = {
|
|
.header = {
|
|
.type = PERF_RECORD_HEADER_ATTR,
|
|
.size = sizeof(struct test_attr_event),
|
|
},
|
|
.id = 1,
|
|
};
|
|
struct test_attr_event event2 = {
|
|
.header = {
|
|
.type = PERF_RECORD_HEADER_ATTR,
|
|
.size = sizeof(struct test_attr_event),
|
|
},
|
|
.id = 2,
|
|
};
|
|
struct mmap_event event3 = {
|
|
.header = {
|
|
.type = PERF_RECORD_MMAP,
|
|
.size = sizeof(struct mmap_event),
|
|
},
|
|
};
|
|
union perf_event *events[] = {
|
|
(union perf_event *)&event1,
|
|
(union perf_event *)&event2,
|
|
(union perf_event *)&event3,
|
|
};
|
|
|
|
err = process_events(events, ARRAY_SIZE(events));
|
|
if (err)
|
|
return -1;
|
|
|
|
return 0;
|
|
}
|