Tejun Heo 006a0973ed writeback: sync_inodes_sb() must write out I_DIRTY_TIME inodes and always call wait_sb_inodes() ... e79729123f ("writeback: don't issue wb_writeback_work if clean") updated writeback path to avoid kicking writeback work items if there are no inodes to be written out; unfortunately, the avoidance logic was too aggressive and broke sync_inodes_sb(). * sync_inodes_sb() must write out I_DIRTY_TIME inodes but I_DIRTY_TIME inodes dont't contribute to bdi/wb_has_dirty_io() tests and were being skipped over. * inodes are taken off wb->b_dirty/io/more_io lists after writeback starts on them. sync_inodes_sb() skipping wait_sb_inodes() when bdi_has_dirty_io() breaks it by making it return while writebacks are in-flight. This patch fixes the breakages by * Removing bdi_has_dirty_io() shortcut from bdi_split_work_to_wbs(). The callers are already testing the condition. * Removing bdi_has_dirty_io() shortcut from sync_inodes_sb() so that it always calls into bdi_split_work_to_wbs() and wait_sb_inodes(). * Making bdi_split_work_to_wbs() consider the b_dirty_time list for WB_SYNC_ALL writebacks. Kudos to Eryu, Dave and Jan for tracking down the issue. Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e79729123f ("writeback: don't issue wb_writeback_work if clean") Link: http://lkml.kernel.org/g/20150812101204.GE17933@dhcp-13-216.nay.redhat.com Reported-and-bisected-by: Eryu Guan <eguan@redhat.com> Cc: Dave Chinner <david@fromorbit.com> Cc: Jan Kara <jack@suse.com> Cc: Ted Ts'o <tytso@google.com> Signed-off-by: Jens Axboe <axboe@fb.com>		2015-08-25 14:35:09 -06:00
..
9p	9p: don't leave a half-initialized inode sitting around	2015-07-12 11:22:05 -04:00
adfs	fs/adfs: remove unneeded cast	2015-06-30 19:44:57 -07:00
affs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
afs
autofs4	make simple_positive() public	2015-06-23 18:02:01 -04:00
befs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
bfs
btrfs	Merge branch 'for-linus-4.2' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2015-08-09 05:56:31 +03:00
cachefiles	Merge branch 'fscache-fixes' into for-next	2015-06-23 18:01:30 -04:00
ceph	ceph: always re-send cap flushes when MDS recovers	2015-07-31 11:38:53 +03:00
cifs	cifs: Unset CIFS_MOUNT_POSIX_PATHS flag when following dfs mounts	2015-06-29 14:50:22 -05:00
coda	fs: cleanup slight list_entry abuse	2015-06-23 18:01:59 -04:00
configfs	configfs: fix kernel infoleak through user-controlled format string	2015-07-17 16:39:53 -07:00
cramfs
debugfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
devpts	devpts: if initialization failed, don't crash when opening /dev/ptmx	2015-06-30 19:44:58 -07:00
dlm
ecryptfs	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
efivarfs
efs	fs/efs: femove unneeded cast	2015-06-25 17:00:42 -07:00
exofs	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
exportfs
ext2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ext3	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2015-06-24 20:07:10 -07:00
ext4	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
f2fs	f2fs: call set_page_dirty to attach i_wb for cgroup	2015-07-25 08:54:26 -07:00
fat
freevxfs	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
fscache
fuse	fs/fuse: fix ioctl type confusion	2015-08-16 12:35:44 -07:00
gfs2	GFS2: merge window	2015-06-27 09:47:46 -07:00
hfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
hfsplus	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
hostfs	Merge branch 'for-linus-1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-06-22 12:51:21 -07:00
hpfs	hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead	2015-07-09 13:35:31 -07:00
hugetlbfs	ipc: use private shmem or hugetlbfs inodes for shm segments.	2015-08-07 04:39:41 +03:00
isofs
jbd
jbd2	Revert "jbd2: speedup jbd2_journal_dirty_metadata()"	2015-06-27 09:41:50 -07:00
jffs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
jfs	A couple trivial fixes and an error path fix	2015-07-16 16:28:28 -07:00
kernfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
lockd
logfs
minix	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ncpfs	ncpfs: successful rename() should invalidate caches for parents	2015-06-14 11:31:39 -04:00
nfs	NFS client bugfixes for Linux 4.2	2015-07-28 09:37:44 -07:00
nfs_common
nfsd	nfsd: do nfs4_check_fh in nfs4_check_file instead of nfs4_check_olstateid	2015-07-31 16:30:26 -04:00
nilfs2	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
nls
notify	fsnotify: fix oops in fsnotify_clear_marks_by_group_flags()	2015-08-07 04:39:41 +03:00
ntfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ocfs2	ocfs2: fix shift left overflow	2015-08-07 04:39:41 +03:00
omfs
openpromfs
overlayfs	fix a braino in ovl_d_select_inode()	2015-07-12 11:22:05 -04:00
proc	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-18 10:49:57 -07:00
pstore	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
qnx4
qnx6	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
quota
ramfs
reiserfs	Merge branch 'akpm' (patches from Andrew)	2015-06-26 09:52:05 -07:00
romfs
squashfs	fs: cleanup slight list_entry abuse	2015-06-23 18:01:59 -04:00
sysfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
sysv	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
tracefs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ubifs	This pull request includes the following UBI/UBIFS changes:	2015-06-25 14:11:34 -07:00
udf	udf: Don't corrupt unalloc spacetable when writing it	2015-07-09 16:38:57 +02:00
ufs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
xfs	xfs: remote attributes need to be considered data	2015-07-29 11:48:02 +10:00
aio.c
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c
block_dev.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
buffer.c
char_dev.c
compat_binfmt_elf.c
compat_ioctl.c	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
compat.c
coredump.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
dax.c	xfs: call dax_fault on read page faults for DAX	2015-07-29 11:48:00 +10:00
dcache.c	fs, file table: reinit files_stat.max_files after deferred memory initialisation	2015-08-07 04:39:40 +03:00
dcookies.c
direct-io.c
drop_caches.c
eventfd.c
eventpoll.c
exec.c
fcntl.c
fhandle.c
file_table.c	fs, file table: reinit files_stat.max_files after deferred memory initialisation	2015-08-07 04:39:40 +03:00
file.c	fs/file.c: __fget() and dup2() atomicity rules	2015-07-01 02:31:08 -04:00
filesystems.c
fs_pin.c
fs_struct.c
fs-writeback.c	writeback: sync_inodes_sb() must write out I_DIRTY_TIME inodes and always call wait_sb_inodes()	2015-08-25 14:35:09 -06:00
inode.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
internal.h	overlayfs: Make f_path always point to the overlay and f_inode to the underlay	2015-06-19 03:19:32 -04:00
ioctl.c
Kconfig
Kconfig.binfmt
libfs.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
locks.c	locks: inline posix_lock_file_wait and flock_lock_file_wait	2015-07-13 06:29:11 -04:00
Makefile
mbcache.c
mount.h	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
mpage.c
namei.c	may_follow_link() should use nd->inode	2015-08-04 23:23:50 -04:00
namespace.c	mnt: In detach_mounts detach the appropriate unmounted mount	2015-07-23 11:31:15 -05:00
no-block.c
nsfs.c
open.c	fs: Call security_ops->inode_killpriv on truncate	2015-06-23 18:01:09 -04:00
pipe.c
pnode.c
pnode.h	mnt: Clarify and correct the disconnect logic in umount_tree	2015-07-22 20:33:27 -05:00
posix_acl.c	fs/posix_acl.c: make posix_acl_create() safer and cleaner	2015-06-23 18:01:07 -04:00
proc_namespace.c	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
read_write.c
readdir.c
select.c
seq_file.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
signalfd.c	signalfd: fix information leak in signalfd_copyinfo	2015-08-07 04:39:40 +03:00
splice.c	Merge branch 'akpm' (patches from Andrew)	2015-06-24 20:47:21 -07:00
stack.c
stat.c
statfs.c
super.c	fs:super:get_anon_bdev: fix race condition could cause dev exceed its upper limitation	2015-07-01 01:50:06 -04:00
sync.c
timerfd.c
utimes.c
xattr.c