Oleg Nesterov 4d9570158b kernel/acct.c: fix the acct->needcheck check in check_free_space() ... As Tsukada explains, the time_is_before_jiffies(acct->needcheck) check is very wrong, we need time_is_after_jiffies() to make sys_acct() work. Ignoring the overflows, the code should "goto out" if needcheck > jiffies, while currently it checks "needcheck < jiffies" and thus in the likely case check_free_space() does nothing until jiffies overflow. In particular this means that sys_acct() is simply broken, acct_on() sets acct->needcheck = jiffies and expects that check_free_space() should set acct->active = 1 after the free-space check, but this won't happen if jiffies increments in between. This was broken by commit 32dc730860 ("get rid of timer in kern/acct.c") in 2011, then another (correct) commit 795a2f22a8 ("acct() should honour the limits from the very beginning") made the problem more visible. Link: http://lkml.kernel.org/r/20171213133940.GA6554@redhat.com Fixes: 32dc730860 ("get rid of timer in kern/acct.c") Reported-by: TSUKADA Koutaro <tsukada@ascade.co.jp> Suggested-by: TSUKADA Koutaro <tsukada@ascade.co.jp> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-01-04 16:45:09 -08:00
..
bpf	bpf: do not allow root to mangle valid pointers	2017-12-21 02:26:29 +01:00
cgroup	Revert "cgroup/cpuset: remove circular dependency deadlock"	2017-12-04 14:55:59 -08:00
configs
debug	kdb: Fix handling of kallsyms_symbol_next() return value	2017-12-06 16:12:43 -06:00
events	locking/barriers: Convert users of lockless_dereference() to READ_ONCE()	2017-12-17 13:57:15 +01:00
gcov
irq	genirq/msi, x86/vector: Prevent reservation mode for non maskable MSI	2017-12-29 21:13:05 +01:00
livepatch	Merge branch 'for-linus' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/jikos/livepatching	2017-11-15 10:21:58 -08:00
locking	locking/lockdep: Remove the cross-release locking checks	2017-12-12 12:38:51 +01:00
power	Revert "cpuset: Make cpuset hotplug synchronous"	2017-12-04 14:41:11 -08:00
printk	remove task and stack pointer printout from oops dump	2017-12-05 08:23:20 -08:00
rcu	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
sched	cpufreq: schedutil: Use idle_calls counter of the remote CPU	2017-12-28 12:26:54 +01:00
time	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-12-31 12:30:34 -08:00
trace	tracing: Fix possible double free on failure of allocating trace buffer	2017-12-27 14:21:27 -05:00
.gitignore
acct.c	kernel/acct.c: fix the acct->needcheck check in check_free_space()	2018-01-04 16:45:09 -08:00
async.c
audit_fsnotify.c
audit_tree.c	Merge branch 'fsnotify' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2017-11-14 14:08:20 -08:00
audit_watch.c
audit.c	Audit: remove unused audit_log_secctx function	2017-11-10 16:08:47 -05:00
audit.h	audit/stable-4.15 PR 20171113	2017-11-15 13:28:48 -08:00
auditfilter.c	audit: filter PATH records keyed on filesystem magic	2017-11-10 16:08:56 -05:00
auditsc.c	audit/stable-4.15 PR 20171113	2017-11-15 13:28:48 -08:00
backtracetest.c
bounds.c
capability.c
compat.c
configs.c
context_tracking.c
cpu_pm.c
cpu.c	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-12-31 12:30:34 -08:00
crash_core.c	kdump: print a message in case parse_crashkernel_mem resulted in zero bytes	2017-11-17 16:10:03 -08:00
crash_dump.c
cred.c
delayacct.c
dma.c
elfcore.c
exec_domain.c
exit.c	arch: define weak abort()	2017-12-14 16:00:49 -08:00
extable.c
fork.c	Merge branch 'x86-pti-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-12-23 11:53:04 -08:00
freezer.c
futex_compat.c
futex.c	futex: futex_wake_op, fix sign_extend32 sign bits	2017-12-10 12:50:57 -08:00
groups.c	kernel: make groups_sort calling a responsibility group_info allocators	2017-12-14 16:00:49 -08:00
hung_task.c
irq_work.c	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:33:11 -08:00
jump_label.c	jump_label: Invoke jump_label_test() via early_initcall()	2017-11-14 08:41:41 +01:00
kallsyms.c	kallsyms: take advantage of the new '%px' format	2017-11-29 10:30:13 -08:00
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	kcov: fix comparison callback signature	2017-12-14 16:00:48 -08:00
kexec_core.c
kexec_file.c
kexec_internal.h
kexec.c
kmod.c
kprobes.c
ksysfs.c
kthread.c	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
latencytop.c
Makefile
memremap.c
module_signing.c
module-internal.h
module.c	kallsyms: take advantage of the new '%px' format	2017-11-29 10:30:13 -08:00
notifier.c
nsproxy.c
padata.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
panic.c	kernel/panic.c: add TAINT_AUX	2017-11-17 16:10:04 -08:00
params.c
pid_namespace.c	pid: remove pidhash	2017-11-17 16:10:04 -08:00
pid.c	pid: Handle failure to allocate the first pid in a pid namespace	2017-12-23 21:00:09 -06:00
profile.c
ptrace.c
range.c
reboot.c	kernel/reboot.c: add devm_register_reboot_notifier()	2017-11-17 16:10:04 -08:00
relay.c
resource.c
seccomp.c	locking/barriers: Convert users of lockless_dereference() to READ_ONCE()	2017-12-17 13:57:15 +01:00
signal.c	Merge branch 'akpm' (patches from Andrew)	2017-11-17 16:56:17 -08:00
smp.c
smpboot.c
smpboot.h
softirq.c	kmemcheck: rip it out	2017-11-15 18:21:05 -08:00
stacktrace.c
stop_machine.c
sys_ni.c
sys.c	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
sysctl_binary.c
sysctl.c	kernel/sysctl.c: code cleanups	2017-11-17 16:10:03 -08:00
task_work.c	locking/barriers: Convert users of lockless_dereference() to READ_ONCE()	2017-12-17 13:57:15 +01:00
taskstats.c
test_kprobes.c
torture.c
tracepoint.c
tsacct.c
ucount.c
uid16.c	kernel: make groups_sort calling a responsibility group_info allocators	2017-12-14 16:00:49 -08:00
umh.c	kernel/umh.c: optimize 'proc_cap_handler()'	2017-11-17 16:10:01 -08:00
up.c
user_namespace.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2017-11-16 12:20:15 -08:00
user-return-notifier.c
user.c
utsname_sysctl.c
utsname.c
watchdog_hld.c
watchdog.c
workqueue_internal.h
workqueue.c	workqueue: remove unneeded kallsyms include	2017-12-11 07:15:43 -08:00