Florian Fainelli 8db0a2ee2c net: bridge: reject DSA-enabled master netdevices as bridge members ... DSA-enabled master network devices with a switch tagging protocol should strip the protocol specific format before handing the frame over to higher layer. When adding such a DSA master network device as a bridge member, we go through the following code path when receiving a frame: __netif_receive_skb_core -> first ptype check against ptype_all is not returning any handler for this skb -> check and invoke rx_handler: -> deliver frame to the bridge layer: br_handle_frame DSA registers a ptype handler with the fake ETH_XDSA ethertype, which is called *after* the bridge-layer rx_handler has run. br_handle_frame() tries to parse the frame it received from the DSA master network device, and will not be able to match any of its conditions and jumps straight at the end of the end of br_handle_frame() and returns RX_HANDLER_CONSUMED there. Since we returned RX_HANDLER_CONSUMED, __netif_receive_skb_core() stops RX processing for this frame and returns NET_RX_SUCCESS, so we never get a chance to call our switch tag packet processing logic and deliver frames to the DSA slave network devices, and so we do not get any functional bridge members at all. Instead of cluttering the bridge receive path with DSA-specific checks, and rely on assumptions about how __netif_receive_skb_core() is processing frames, we simply deny adding the DSA master network device (conduit interface) as a bridge member, leaving only the slave DSA network devices to be bridge members, since those will work correctly in all circumstances. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2015-01-19 15:45:10 -05:00
..
netfilter	net: rename vlan_tx_* helpers since "tx" is misleading there	2015-01-13 17:51:08 -05:00
br_device.c	bridge: Add filtering support for default_pvid	2014-10-05 21:21:37 -04:00
br_fdb.c	netlink: make nlmsg_end() and genlmsg_end() void	2015-01-18 01:03:45 -05:00
br_forward.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-11-01 14:53:27 -04:00
br_if.c	net: bridge: reject DSA-enabled master netdevices as bridge members	2015-01-19 15:45:10 -05:00
br_input.c	bridge: only provide proxy ARP when CONFIG_INET is enabled	2015-01-14 15:08:02 -05:00
br_ioctl.c
br_mdb.c	netlink: make nlmsg_end() and genlmsg_end() void	2015-01-18 01:03:45 -05:00
br_multicast.c	bridge: fix netfilter/NF_BR_LOCAL_OUT for own, locally generated queries	2014-11-17 12:38:02 +01:00
br_netfilter.c	net: rename vlan_tx_* helpers since "tx" is misleading there	2015-01-13 17:51:08 -05:00
br_netlink.c	netlink: make nlmsg_end() and genlmsg_end() void	2015-01-18 01:03:45 -05:00
br_nf_core.c	netfilter: bridge: move br_netfilter out of the core	2014-09-26 18:42:31 +02:00
br_private_stp.h
br_private.h	net: replace br_fdb_external_learn_* calls with switchdev notifier events	2015-01-18 00:23:57 -05:00
br_stp_bpdu.c
br_stp_if.c	net: bridge: add a br_set_state helper function	2014-10-01 22:03:50 -04:00
br_stp_timer.c	net: bridge: add a br_set_state helper function	2014-10-01 22:03:50 -04:00
br_stp.c	bridge: call netdev_sw_port_stp_update when bridge port STP status changes	2014-12-02 20:01:22 -08:00
br_sysfs_br.c	bridge: Add a default_pvid sysfs attribute	2014-10-05 21:21:36 -04:00
br_sysfs_if.c	bridge: Add support for IEEE 802.11 Proxy ARP	2014-10-27 19:02:04 -04:00
br_vlan.c	net: rename vlan_tx_* helpers since "tx" is misleading there	2015-01-13 17:51:08 -05:00
br.c	net: replace br_fdb_external_learn_* calls with switchdev notifier events	2015-01-18 00:23:57 -05:00
Kconfig
Makefile	netfilter: bridge: build br_nf_core only if required	2014-09-30 14:07:51 -04:00