kernel_optimize_test/net/core
Eric Dumazet 4d77d2b567 flow_dissector: use a 64bit load/store
Le lundi 28 novembre 2011 à 19:06 -0500, David Miller a écrit :
> From: Dimitris Michailidis <dm@chelsio.com>
> Date: Mon, 28 Nov 2011 08:25:39 -0800
>
> >> +bool skb_flow_dissect(const struct sk_buff *skb, struct flow_keys
> >> *flow)
> >> +{
> >> +	int poff, nhoff = skb_network_offset(skb);
> >> +	u8 ip_proto;
> >> +	u16 proto = skb->protocol;
> >
> > __be16 instead of u16 for proto?
>
> I'll take care of this when I apply these patches.

( CC trimmed )

Thanks David !

Here is a small patch to use one 64bit load/store on x86_64 instead of
two 32bit load/stores.

[PATCH net-next] flow_dissector: use a 64bit load/store

gcc compiler is smart enough to use a single load/store if we
memcpy(dptr, sptr, 8) on x86_64, regardless of
CONFIG_CC_OPTIMIZE_FOR_SIZE

In IP header, daddr immediately follows saddr, this wont change in the
future. We only need to make sure our flow_keys (src,dst) fields wont
break the rule.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-11-29 13:17:03 -05:00
..
datagram.c
dev_addr_lists.c
dev.c bql: Byte queue limits 2011-11-29 12:46:19 -05:00
drop_monitor.c
dst.c
ethtool.c
fib_rules.c
filter.c
flow_dissector.c flow_dissector: use a 64bit load/store 2011-11-29 13:17:03 -05:00
flow.c
gen_estimator.c
gen_stats.c
iovec.c
kmap_skb.h
link_watch.c
Makefile net: introduce skb_flow_dissect() 2011-11-28 19:09:07 -05:00
neighbour.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-26 14:47:03 -05:00
net_namespace.c
net-sysfs.c bql: Byte queue limits 2011-11-29 12:46:19 -05:00
net-sysfs.h
net-traces.c
netevent.c
netpoll.c net: Add queue state xoff flag for stack 2011-11-29 12:46:19 -05:00
netprio_cgroup.c net: treewide use of RCU_INIT_POINTER 2011-11-23 18:48:19 -05:00
pktgen.c net: Add queue state xoff flag for stack 2011-11-29 12:46:19 -05:00
request_sock.c
rtnetlink.c
scm.c
secure_seq.c
skbuff.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-26 14:47:03 -05:00
sock.c net: optimize socket timestamping 2011-11-29 00:27:11 -05:00
stream.c
sysctl_net_core.c
timestamping.c
user_dma.c
utils.c