Roman Mashak 51d4740f88 net sched actions: return explicit error when tunnel_key mode is not specified ... If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bogus 'struct tc_action *' object, this results in crash: % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1 [ 35.805515] general protection fault: 0000 [#1] SMP PTI [ 35.806161] Modules linked in: act_tunnel_key kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd glue_helper cryptd serio_raw [ 35.808233] CPU: 1 PID: 428 Comm: tc Not tainted 4.16.0-rc4+ #286 [ 35.808929] RIP: 0010:tcf_action_init+0x90/0x190 [ 35.809457] RSP: 0018:ffffb8edc068b9a0 EFLAGS: 00010206 [ 35.810053] RAX: 1320c000000a0003 RBX: 0000000000000001 RCX: 0000000000000000 [ 35.810866] RDX: 0000000000000070 RSI: 0000000000007965 RDI: ffffb8edc068b910 [ 35.811660] RBP: ffffb8edc068b9d0 R08: 0000000000000000 R09: ffffb8edc068b808 [ 35.812463] R10: ffffffffc02bf040 R11: 0000000000000040 R12: ffffb8edc068bb38 [ 35.813235] R13: 0000000000000000 R14: 0000000000000000 R15: ffffb8edc068b910 [ 35.814006] FS: 00007f3d0d8556c0(0000) GS:ffff91d1dbc40000(0000) knlGS:0000000000000000 [ 35.814881] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 35.815540] CR2: 000000000043f720 CR3: 0000000019248001 CR4: 00000000001606a0 [ 35.816457] Call Trace: [ 35.817158] tc_ctl_action+0x11a/0x220 [ 35.817795] rtnetlink_rcv_msg+0x23d/0x2e0 [ 35.818457] ? __slab_alloc+0x1c/0x30 [ 35.819079] ? __kmalloc_node_track_caller+0xb1/0x2b0 [ 35.819544] ? rtnl_calcit.isra.30+0xe0/0xe0 [ 35.820231] netlink_rcv_skb+0xce/0x100 [ 35.820744] netlink_unicast+0x164/0x220 [ 35.821500] netlink_sendmsg+0x293/0x370 [ 35.822040] sock_sendmsg+0x30/0x40 [ 35.822508] ___sys_sendmsg+0x2c5/0x2e0 [ 35.823149] ? pagecache_get_page+0x27/0x220 [ 35.823714] ? filemap_fault+0xa2/0x640 [ 35.824423] ? page_add_file_rmap+0x108/0x200 [ 35.825065] ? alloc_set_pte+0x2aa/0x530 [ 35.825585] ? finish_fault+0x4e/0x70 [ 35.826140] ? __handle_mm_fault+0xbc1/0x10d0 [ 35.826723] ? __sys_sendmsg+0x41/0x70 [ 35.827230] __sys_sendmsg+0x41/0x70 [ 35.827710] do_syscall_64+0x68/0x120 [ 35.828195] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 35.828859] RIP: 0033:0x7f3d0ca4da67 [ 35.829331] RSP: 002b:00007ffc9f284338 EFLAGS: 00000246 ORIG_RAX: 000000000000002e [ 35.830304] RAX: ffffffffffffffda RBX: 00007ffc9f284460 RCX: 00007f3d0ca4da67 [ 35.831247] RDX: 0000000000000000 RSI: 00007ffc9f2843b0 RDI: 0000000000000003 [ 35.832167] RBP: 000000005aa6a7a9 R08: 0000000000000001 R09: 0000000000000000 [ 35.833075] R10: 00000000000005f1 R11: 0000000000000246 R12: 0000000000000000 [ 35.833997] R13: 00007ffc9f2884c0 R14: 0000000000000001 R15: 0000000000674640 [ 35.834923] Code: 24 30 bb 01 00 00 00 45 31 f6 eb 5e 8b 50 08 83 c2 07 83 e2 fc 83 c2 70 49 8b 07 48 8b 40 70 48 85 c0 74 10 48 89 14 24 4c 89 ff <ff> d0 48 8b 14 24 48 01 c2 49 01 d6 45 85 ed 74 05 41 83 47 2c [ 35.837442] RIP: tcf_action_init+0x90/0x190 RSP: ffffb8edc068b9a0 [ 35.838291] ---[ end trace a095c06ee4b97a26 ]--- Fixes: d0f6dd8a91 ("net/sched: Introduce act_tunnel_key") Signed-off-by: Roman Mashak <mrv@mojatatu.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-03-15 14:43:41 -04:00
..
act_api.c	idr: Rename idr_for_each_entry_ext	2018-02-06 16:41:28 -05:00
act_bpf.c
act_connmark.c
act_csum.c	net: use skb_is_gso_sctp() instead of open-coding	2018-03-09 11:41:47 -05:00
act_gact.c
act_ife.c
act_ipt.c
act_meta_mark.c
act_meta_skbprio.c
act_meta_skbtcindex.c
act_mirred.c
act_nat.c
act_pedit.c
act_police.c
act_sample.c
act_simple.c
act_skbedit.c
act_skbmod.c
act_tunnel_key.c	net sched actions: return explicit error when tunnel_key mode is not specified	2018-03-15 14:43:41 -04:00
act_vlan.c
cls_api.c	net: sched: report if filter is too large to dump	2018-02-20 21:57:17 -05:00
cls_basic.c	cls_basic: Convert to use idr_alloc_u32	2018-02-06 16:41:26 -05:00
cls_bpf.c	cls_bpf: Convert to use idr_alloc_u32	2018-02-06 16:41:26 -05:00
cls_cgroup.c	net: sched: propagate extack to cls->destroy callbacks	2018-01-24 16:01:09 -05:00
cls_flow.c	net: sched: propagate extack to cls->destroy callbacks	2018-01-24 16:01:09 -05:00
cls_flower.c	cls_flower: Convert to idr_alloc_u32	2018-02-06 16:41:26 -05:00
cls_fw.c	net: sched: propagate extack to cls->destroy callbacks	2018-01-24 16:01:09 -05:00
cls_matchall.c	cls_matchall: propagate extack to delete callback	2018-01-24 16:01:10 -05:00
cls_route.c	net: sched: propagate extack to cls->destroy callbacks	2018-01-24 16:01:09 -05:00
cls_rsvp6.c
cls_rsvp.c
cls_rsvp.h	net: sched: propagate extack to cls->destroy callbacks	2018-01-24 16:01:09 -05:00
cls_tcindex.c	net: sched: propagate extack to cls->destroy callbacks	2018-01-24 16:01:09 -05:00
cls_u32.c	net: sched: fix tc_u_common lookup	2018-02-13 12:29:02 -05:00
em_canid.c
em_cmp.c
em_ipset.c
em_meta.c
em_nbyte.c	net: sched: em_nbyte: don't add the data offset twice	2018-01-24 14:52:40 -05:00
em_text.c
em_u32.c
ematch.c
Kconfig	net/sched: kconfig: Remove blank help texts	2018-01-31 10:26:30 -05:00
Makefile
sch_api.c	net: sched: introduce ingress/egress block index attributes for qdisc	2018-01-17 14:53:57 -05:00
sch_atm.c
sch_blackhole.c
sch_cbq.c
sch_cbs.c
sch_choke.c
sch_codel.c
sch_drr.c
sch_dsmark.c
sch_fifo.c
sch_fq_codel.c
sch_fq.c
sch_generic.c	net_sched: implement ->change_tx_queue_len() for pfifo_fast	2018-01-29 12:42:15 -05:00
sch_gred.c
sch_hfsc.c
sch_hhf.c
sch_htb.c
sch_ingress.c	net: sched: allow ingress and clsact qdiscs to share filter blocks	2018-01-17 14:53:57 -05:00
sch_mq.c
sch_mqprio.c
sch_multiq.c
sch_netem.c	sch_netem: fix skb leak in netem_enqueue()	2018-03-07 11:18:14 -05:00
sch_pie.c
sch_plug.c
sch_prio.c	net/sched/sch_prio.c: work around gcc-4.4.4 union initializer issues	2018-01-18 21:11:31 -05:00
sch_qfq.c
sch_red.c
sch_sfb.c
sch_sfq.c
sch_tbf.c	net: sched: tbf: handle GSO_BY_FRAGS case in enqueue	2018-03-04 17:49:17 -05:00
sch_teql.c