forked from luck/tmp_suning_uos_patched
691cd0c2ee
I'm currently working on a port to a CPCI board with a MPC5200. When testing the PCI interrupt routing, I discovered the following: Even devices which don't use interrupts (-> PCI Spec.: Interrupt Pin Register is zero), get an interrupt assigned (this is at least true for most of the PPC-targets I looked at). The cause is pretty obvious in drivers/pci/setup-irq.c. I guess at least in an ideal world with correctly designed hardware, the code should rather look as in the patch below. Of course it doesn't hurt anybody to have an unuseable IRQ assigned to a PCI-to-PCI-bridge (or something alike), but to me it seems a bit strange. Please correct me, if I'm mislead. The patch below is tested on the above mentioned CPCI-MPC5200 board and is compiler tested with the latest git-repository kernel on x86. Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@elte.hu> Cc: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
67 lines
1.7 KiB
C
67 lines
1.7 KiB
C
/*
|
|
* drivers/pci/setup-irq.c
|
|
*
|
|
* Extruded from code written by
|
|
* Dave Rusling (david.rusling@reo.mts.dec.com)
|
|
* David Mosberger (davidm@cs.arizona.edu)
|
|
* David Miller (davem@redhat.com)
|
|
*
|
|
* Support routines for initializing a PCI subsystem.
|
|
*/
|
|
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/cache.h>
|
|
|
|
|
|
static void __init
|
|
pdev_fixup_irq(struct pci_dev *dev,
|
|
u8 (*swizzle)(struct pci_dev *, u8 *),
|
|
int (*map_irq)(struct pci_dev *, u8, u8))
|
|
{
|
|
u8 pin, slot;
|
|
int irq = 0;
|
|
|
|
/* If this device is not on the primary bus, we need to figure out
|
|
which interrupt pin it will come in on. We know which slot it
|
|
will come in on 'cos that slot is where the bridge is. Each
|
|
time the interrupt line passes through a PCI-PCI bridge we must
|
|
apply the swizzle function. */
|
|
|
|
pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
|
|
/* Cope with illegal. */
|
|
if (pin > 4)
|
|
pin = 1;
|
|
|
|
if (pin != 0) {
|
|
/* Follow the chain of bridges, swizzling as we go. */
|
|
slot = (*swizzle)(dev, &pin);
|
|
|
|
irq = (*map_irq)(dev, slot, pin);
|
|
if (irq == -1)
|
|
irq = 0;
|
|
}
|
|
dev->irq = irq;
|
|
|
|
pr_debug("PCI: fixup irq: (%s) got %d\n",
|
|
dev->dev.kobj.name, dev->irq);
|
|
|
|
/* Always tell the device, so the driver knows what is
|
|
the real IRQ to use; the device does not use it. */
|
|
pcibios_update_irq(dev, irq);
|
|
}
|
|
|
|
void __init
|
|
pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *),
|
|
int (*map_irq)(struct pci_dev *, u8, u8))
|
|
{
|
|
struct pci_dev *dev = NULL;
|
|
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
|
|
pdev_fixup_irq(dev, swizzle, map_irq);
|
|
}
|
|
}
|