Jason Yan b90cd6f2b9 scsi: libsas: fix a race condition when smp task timeout ... When the lldd is processing the complete sas task in interrupt and set the task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to be triggered at the same time. And smp_task_timedout() will complete the task wheter the SAS_TASK_STATE_DONE is set or not. Then the sas task may freed before lldd end the interrupt process. Thus a use-after-free will happen. Fix this by calling the complete() only when SAS_TASK_STATE_DONE is not set. And remove the check of the return value of the del_timer(). Once the LLDD sets DONE, it must call task->done(), which will call smp_task_done()->complete() and the task will be completed and freed correctly. Reported-by: chenxiang <chenxiang66@hisilicon.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> CC: John Garry <john.garry@huawei.com> CC: Johannes Thumshirn <jthumshirn@suse.de> CC: Ewan Milne <emilne@redhat.com> CC: Christoph Hellwig <hch@lst.de> CC: Tomas Henzl <thenzl@redhat.com> CC: Dan Williams <dan.j.williams@intel.com> CC: Hannes Reinecke <hare@suse.com> Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: John Garry <john.garry@huawei.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2018-09-25 21:20:23 -04:00
..
Kconfig
Makefile
sas_ata.c	scsi: libsas: check the ata device status by ata_dev_enabled()	2018-09-25 21:20:23 -04:00
sas_discover.c	scsi: libsas: make the lldd_port_deformed method optional	2018-09-25 21:20:23 -04:00
sas_dump.c
sas_dump.h
sas_event.c
sas_expander.c	scsi: libsas: fix a race condition when smp task timeout	2018-09-25 21:20:23 -04:00
sas_host_smp.c
sas_init.c
sas_internal.h
sas_phy.c
sas_port.c
sas_scsi_host.c	scsi: read host_busy via scsi_host_busy()	2018-06-26 12:53:26 -04:00
sas_task.c