Ye Bin 2bcab471a2 block: Fix fsync always failed if once failed ... commit 8a7518931baa8ea023700987f3db31cb0a80610b upstream. We do test with inject error fault base on v4.19, after test some time we found sync /dev/sda always failed. [root@localhost] sync /dev/sda sync: error syncing '/dev/sda': Input/output error scsi log as follows: [19069.812296] sd 0:0:0:0: [sda] tag#64 Send: scmd 0x00000000d03a0b6b [19069.812302] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00 [19069.812533] sd 0:0:0:0: [sda] tag#64 Done: SUCCESS Result: hostbyte=DID_OK driverbyte=DRIVER_OK [19069.812536] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00 [19069.812539] sd 0:0:0:0: [sda] tag#64 scsi host busy 1 failed 0 [19069.812542] sd 0:0:0:0: Notifying upper driver of completion (result 0) [19069.812546] sd 0:0:0:0: [sda] tag#64 sd_done: completed 0 of 0 bytes [19069.812549] sd 0:0:0:0: [sda] tag#64 0 sectors total, 0 bytes done. [19069.812564] print_req_error: I/O error, dev sda, sector 0 ftrace log as follows: rep-306069 [007] .... 19654.923315: block_bio_queue: 8,0 FWS 0 + 0 [rep] rep-306069 [007] .... 19654.923333: block_getrq: 8,0 FWS 0 + 0 [rep] kworker/7:1H-250 [007] .... 19654.923352: block_rq_issue: 8,0 FF 0 () 0 + 0 [kworker/7:1H] <idle>-0 [007] ..s. 19654.923562: block_rq_complete: 8,0 FF () 18446744073709551615 + 0 [0] <idle>-0 [007] d.s. 19654.923576: block_rq_complete: 8,0 WS () 0 + 0 [-5] As 8d6996630c introduce 'fq->rq_status', this data only update when 'flush_rq' reference count isn't zero. If flush request once failed and record error code in 'fq->rq_status'. If there is no chance to update 'fq->rq_status',then do fsync will always failed. To address this issue reset 'fq->rq_status' after return error code to upper layer. Fixes: 8d6996630c03("block: fix null pointer dereference in blk_mq_rq_timed_out()") Signed-off-by: Ye Bin <yebin10@huawei.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Link: https://lore.kernel.org/r/20211129012659.1553733-1-yebin10@huawei.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-01-27 10:54:30 +01:00
..
partitions	partitions: msdos: fix one-byte get_unaligned()	2021-07-20 16:05:39 +02:00
badblocks.c
bfq-cgroup.c
bfq-iosched.c	Revert "block, bfq: honor already-setup queue merges"	2021-10-06 15:55:56 +02:00
bfq-iosched.h
bfq-wf2q.c
bio-integrity.c
bio.c	bio: fix page leak bio_add_hw_page failure	2021-09-15 09:50:47 +02:00
blk-cgroup-rwstat.c
blk-cgroup-rwstat.h
blk-cgroup.c	blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd	2021-09-30 10:11:07 +02:00
blk-core.c	blkcg: Remove extra blkcg_bio_issue_init	2021-11-26 10:39:13 +01:00
blk-crypto-fallback.c
blk-crypto-internal.h
blk-crypto.c	blk-crypto: fix check for too-large dun_bytes	2021-09-15 09:50:30 +02:00
blk-exec.c
blk-flush.c	block: Fix fsync always failed if once failed	2022-01-27 10:54:30 +01:00
blk-integrity.c	block: flush the integrity workqueue in blk_integrity_unregister	2021-09-30 10:11:06 +02:00
blk-ioc.c
blk-iocost.c	iocost: Fix divide-by-zero on donation from low hweight cgroup	2021-12-22 09:30:57 +01:00
blk-iolatency.c	blk-iolatency: error out if blk_get_queue() failed in iolatency_set_limit()	2021-08-12 13:22:08 +02:00
blk-lib.c
blk-map.c
blk-merge.c	block: return ELEVATOR_DISCARD_MERGE if possible	2021-09-15 09:50:28 +02:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output	2021-10-27 09:56:46 +02:00
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
blk-mq-sched.h
blk-mq-sysfs.c
blk-mq-tag.c	blk-mq: avoid to iterate over stale request	2021-09-30 10:11:05 +02:00
blk-mq-tag.h
blk-mq-virtio.c
blk-mq.c	block: remove inaccurate requeue check	2021-11-18 14:03:58 +01:00
blk-mq.h
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2022-01-27 10:54:08 +01:00
blk-pm.h
blk-rq-qos.c	rq-qos: fix missed wake-ups in rq_qos_throttle try two	2021-07-19 09:45:00 +02:00
blk-rq-qos.h	block: fix race between adding/removing rq qos and normal IO	2021-07-14 16:56:00 +02:00
blk-settings.c
blk-stat.c
blk-stat.h
blk-sysfs.c
blk-throttle.c	blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()	2021-09-26 14:09:01 +02:00
blk-timeout.c
blk-wbt.c	blk-wbt: make sure throttle is enabled properly	2021-07-14 16:56:12 +02:00
blk-wbt.h	blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()	2021-07-14 16:56:12 +02:00
blk-zoned.c	blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN	2021-09-18 13:40:06 +02:00
blk.h	block: bump max plugged deferred size from 16 to 32	2021-11-18 14:03:57 +01:00
bounce.c
bsg-lib.c
bsg.c	scsi: bsg: Remove support for SCSI_IOCTL_SEND_COMMAND	2021-09-18 13:40:11 +02:00
cmdline-parser.c
elevator.c	block: return ELEVATOR_DISCARD_MERGE if possible	2021-09-15 09:50:28 +02:00
genhd.c
ioctl.c
ioprio.c	block: fix ioprio_get(IOPRIO_WHO_PGRP) vs setuid(2)	2021-12-14 11:32:40 +01:00
Kconfig
Kconfig.iosched
keyslot-manager.c
kyber-iosched.c
Makefile
mq-deadline.c	block: return ELEVATOR_DISCARD_MERGE if possible	2021-09-15 09:50:28 +02:00
opal_proto.h
scsi_ioctl.c
sed-opal.c
t10-pi.c