forked from luck/tmp_suning_uos_patched
078a55fc82
commit 3747069b25e419f6b51395f48127e9812abc3596 upstream.
The __cpuinit type of throwaway sections might have made sense
some time ago when RAM was more constrained, but now the savings
do not offset the cost and complications. For example, the fix in
commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
is a good example of the nasty type of bugs that can be created
with improper use of the various __init prefixes.
After a discussion on LKML[1] it was decided that cpuinit should go
the way of devinit and be phased out. Once all the users are gone,
we can then finally remove the macros themselves from linux/init.h.
Note that some harmless section mismatch warnings may result, since
notify_cpu_starting() and cpu_up() are arch independent (kernel/cpu.c)
and are flagged as __cpuinit -- so if we remove the __cpuinit from
the arch specific callers, we will also get section mismatch warnings.
As an intermediate step, we intend to turn the linux/init.h cpuinit
related content into no-ops as early as possible, since that will get
rid of these warnings. In any case, they are temporary and harmless.
Here, we remove all the MIPS __cpuinit from C code and __CPUINIT
from asm files. MIPS is interesting in this respect, because there
are also uasm users hiding behind their own renamed versions of the
__cpuinit macros.
[1] https://lkml.org/lkml/2013/5/20/589
[ralf@linux-mips.org: Folded in Paul's followup fix.]
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/5494/
Patchwork: https://patchwork.linux-mips.org/patch/5495/
Patchwork: https://patchwork.linux-mips.org/patch/5509/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
152 lines
3.6 KiB
C
152 lines
3.6 KiB
C
/*
|
|
* Count register synchronisation.
|
|
*
|
|
* All CPUs will have their count registers synchronised to the CPU0 next time
|
|
* value. This can cause a small timewarp for CPU0. All other CPU's should
|
|
* not have done anything significant (but they may have had interrupts
|
|
* enabled briefly - prom_smp_finish() should not be responsible for enabling
|
|
* interrupts...)
|
|
*
|
|
* FIXME: broken for SMTC
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/irqflags.h>
|
|
#include <linux/cpumask.h>
|
|
|
|
#include <asm/r4k-timer.h>
|
|
#include <linux/atomic.h>
|
|
#include <asm/barrier.h>
|
|
#include <asm/mipsregs.h>
|
|
|
|
static atomic_t count_start_flag = ATOMIC_INIT(0);
|
|
static atomic_t count_count_start = ATOMIC_INIT(0);
|
|
static atomic_t count_count_stop = ATOMIC_INIT(0);
|
|
static atomic_t count_reference = ATOMIC_INIT(0);
|
|
|
|
#define COUNTON 100
|
|
#define NR_LOOPS 5
|
|
|
|
void synchronise_count_master(int cpu)
|
|
{
|
|
int i;
|
|
unsigned long flags;
|
|
unsigned int initcount;
|
|
|
|
#ifdef CONFIG_MIPS_MT_SMTC
|
|
/*
|
|
* SMTC needs to synchronise per VPE, not per CPU
|
|
* ignore for now
|
|
*/
|
|
return;
|
|
#endif
|
|
|
|
printk(KERN_INFO "Synchronize counters for CPU %u: ", cpu);
|
|
|
|
local_irq_save(flags);
|
|
|
|
/*
|
|
* Notify the slaves that it's time to start
|
|
*/
|
|
atomic_set(&count_reference, read_c0_count());
|
|
atomic_set(&count_start_flag, cpu);
|
|
smp_wmb();
|
|
|
|
/* Count will be initialised to current timer for all CPU's */
|
|
initcount = read_c0_count();
|
|
|
|
/*
|
|
* We loop a few times to get a primed instruction cache,
|
|
* then the last pass is more or less synchronised and
|
|
* the master and slaves each set their cycle counters to a known
|
|
* value all at once. This reduces the chance of having random offsets
|
|
* between the processors, and guarantees that the maximum
|
|
* delay between the cycle counters is never bigger than
|
|
* the latency of information-passing (cachelines) between
|
|
* two CPUs.
|
|
*/
|
|
|
|
for (i = 0; i < NR_LOOPS; i++) {
|
|
/* slaves loop on '!= 2' */
|
|
while (atomic_read(&count_count_start) != 1)
|
|
mb();
|
|
atomic_set(&count_count_stop, 0);
|
|
smp_wmb();
|
|
|
|
/* this lets the slaves write their count register */
|
|
atomic_inc(&count_count_start);
|
|
|
|
/*
|
|
* Everyone initialises count in the last loop:
|
|
*/
|
|
if (i == NR_LOOPS-1)
|
|
write_c0_count(initcount);
|
|
|
|
/*
|
|
* Wait for all slaves to leave the synchronization point:
|
|
*/
|
|
while (atomic_read(&count_count_stop) != 1)
|
|
mb();
|
|
atomic_set(&count_count_start, 0);
|
|
smp_wmb();
|
|
atomic_inc(&count_count_stop);
|
|
}
|
|
/* Arrange for an interrupt in a short while */
|
|
write_c0_compare(read_c0_count() + COUNTON);
|
|
atomic_set(&count_start_flag, 0);
|
|
|
|
local_irq_restore(flags);
|
|
|
|
/*
|
|
* i386 code reported the skew here, but the
|
|
* count registers were almost certainly out of sync
|
|
* so no point in alarming people
|
|
*/
|
|
printk("done.\n");
|
|
}
|
|
|
|
void synchronise_count_slave(int cpu)
|
|
{
|
|
int i;
|
|
unsigned int initcount;
|
|
|
|
#ifdef CONFIG_MIPS_MT_SMTC
|
|
/*
|
|
* SMTC needs to synchronise per VPE, not per CPU
|
|
* ignore for now
|
|
*/
|
|
return;
|
|
#endif
|
|
|
|
/*
|
|
* Not every cpu is online at the time this gets called,
|
|
* so we first wait for the master to say everyone is ready
|
|
*/
|
|
|
|
while (atomic_read(&count_start_flag) != cpu)
|
|
mb();
|
|
|
|
/* Count will be initialised to next expire for all CPU's */
|
|
initcount = atomic_read(&count_reference);
|
|
|
|
for (i = 0; i < NR_LOOPS; i++) {
|
|
atomic_inc(&count_count_start);
|
|
while (atomic_read(&count_count_start) != 2)
|
|
mb();
|
|
|
|
/*
|
|
* Everyone initialises count in the last loop:
|
|
*/
|
|
if (i == NR_LOOPS-1)
|
|
write_c0_count(initcount);
|
|
|
|
atomic_inc(&count_count_stop);
|
|
while (atomic_read(&count_count_stop) != 2)
|
|
mb();
|
|
}
|
|
/* Arrange for an interrupt in a short while */
|
|
write_c0_compare(read_c0_count() + COUNTON);
|
|
}
|
|
#undef NR_LOOPS
|