Chuck Lever d1205f87bb NFS: NFSv4 readdir loses entries ... On recent 2.6.38-rc kernels, connectathon basic test 6 fails on NFSv4 mounts of OpenSolaris with something like: > ./test6: readdir > ./test6: (/mnt/klimt/matisse.test) didn't read expected 'file.12' dir entry, pass 0 > ./test6: (/mnt/klimt/matisse.test) didn't read expected 'file.82' dir entry, pass 0 > ./test6: (/mnt/klimt/matisse.test) didn't read expected 'file.164' dir entry, pass 0 > ./test6: (/mnt/klimt/matisse.test) Test failed with 3 errors > basic tests failed > Tests failed, leaving /mnt/klimt mounted > [cel@matisse cthon04]$ I narrowed the problem down to nfs4_decode_dirent() reporting that the decode buffer had overflowed while decoding the entries for those missing files. verify_attr_len() assumes both it's pointer arguments reside on the same page. When these arguments point to locations on two different pages, verify_attr_len() can report false errors. This can happen now that a large NFSv4 readdir result can span pages. We have reasonably good checking in nfs4_decode_dirent() anyway, so it should be safe to simply remove the extra checking. At a guess, this was introduced by commit 6650239a, "NFS: Don't use vm_map_ram() in readdir". Cc: stable@kernel.org [2.6.37] Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>		2011-01-28 13:41:35 -05:00
..
cache_lib.c
cache_lib.h
callback_proc.c	NFS fix cb_sequence error processing	2011-01-25 15:26:51 -05:00
callback_xdr.c	NFS do not find client in NFSv4 pg_authenticate	2011-01-25 15:26:51 -05:00
callback.c	NFS do not find client in NFSv4 pg_authenticate	2011-01-25 15:26:51 -05:00
callback.h	NFS do not find client in NFSv4 pg_authenticate	2011-01-25 15:26:51 -05:00
client.c	NFS do not find client in NFSv4 pg_authenticate	2011-01-25 15:26:51 -05:00
delegation.c	NFS: Fix an NFS client lockdep issue	2011-01-28 13:37:09 -05:00
delegation.h
dir.c
direct.c
dns_resolve.c
dns_resolve.h
file.c
fscache-index.c
fscache.c
fscache.h
getroot.c
idmap.c
inode.c	NFS: nfs_wcc_update_inode() should set nfsi->attr_gencount	2011-01-25 15:28:21 -05:00
internal.h	NFS do not find client in NFSv4 pg_authenticate	2011-01-25 15:26:51 -05:00
iostat.h
Kconfig
Makefile
mount_clnt.c
namespace.c
nfs2xdr.c
nfs3acl.c	NFS: Prevent memory allocation failure in nfsacl_encode()	2011-01-25 15:24:47 -05:00
nfs3proc.c
nfs3xdr.c
nfs4_fs.h
nfs4filelayout.c
nfs4filelayout.h
nfs4filelayoutdev.c
nfs4namespace.c
nfs4proc.c	NFS construct consistent co_ownerid for v4.1	2011-01-25 22:49:14 -05:00
nfs4renewd.c
nfs4state.c	NFS do not find client in NFSv4 pg_authenticate	2011-01-25 15:26:51 -05:00
nfs4xdr.c	NFS: NFSv4 readdir loses entries	2011-01-28 13:41:35 -05:00
nfsroot.c
pagelist.c
pnfs.c	NFS improve pnfs_put_deviceid_cache debug print	2011-01-25 15:26:51 -05:00
pnfs.h
proc.c
read.c
super.c
symlink.c
sysctl.c
unlink.c
write.c