Theodore Ts'o 960fd856fd ext4: fix ext4_get_group_number() ... The function ext4_get_group_number() was introduced as an optimization in commit bd86298e60. Unfortunately, this commit incorrectly calculate the group number for file systems with a 1k block size (when s_first_data_block is 1 instead of zero). This could cause the following kernel BUG: [ 568.877799] ------------[ cut here ]------------ [ 568.877833] kernel BUG at fs/ext4/mballoc.c:3728! [ 568.877840] Oops: Exception in kernel mode, sig: 5 [#1] [ 568.877845] SMP NR_CPUS=32 NUMA pSeries [ 568.877852] Modules linked in: binfmt_misc [ 568.877861] CPU: 1 PID: 3516 Comm: fs_mark Not tainted 3.10.0-03216-g7c6809f-dirty #1 [ 568.877867] task: c0000001fb0b8000 ti: c0000001fa954000 task.ti: c0000001fa954000 [ 568.877873] NIP: c0000000002f42a4 LR: c0000000002f4274 CTR: c000000000317ef8 [ 568.877879] REGS: c0000001fa956ed0 TRAP: 0700 Not tainted (3.10.0-03216-g7c6809f-dirty) [ 568.877884] MSR: 8000000000029032 <SF,EE,ME,IR,DR,RI> CR: 24000428 XER: 00000000 [ 568.877902] SOFTE: 1 [ 568.877905] CFAR: c0000000002b5464 [ 568.877908] GPR00: 0000000000000001 c0000001fa957150 c000000000c6a408 c0000001fb588000 GPR04: 0000000000003fff c0000001fa9571c0 c0000001fa9571c4 000138098c50625f GPR08: 1301200000000000 0000000000000002 0000000000000001 0000000000000000 GPR12: 0000000024000422 c00000000f33a300 0000000000008000 c0000001fa9577f0 GPR16: c0000001fb7d0100 c000000000c29190 c0000000007f46e8 c000000000a14672 GPR20: 0000000000000001 0000000000000008 ffffffffffffffff 0000000000000000 GPR24: 0000000000000100 c0000001fa957278 c0000001fdb2bc78 c0000001fa957288 GPR28: 0000000000100100 c0000001fa957288 c0000001fb588000 c0000001fdb2bd10 [ 568.877993] NIP [c0000000002f42a4] .ext4_mb_release_group_pa+0xec/0x1c0 [ 568.877999] LR [c0000000002f4274] .ext4_mb_release_group_pa+0xbc/0x1c0 [ 568.878004] Call Trace: [ 568.878008] [c0000001fa957150] [c0000000002f4274] .ext4_mb_release_group_pa+0xbc/0x1c0 (unreliable) [ 568.878017] [c0000001fa957200] [c0000000002fb070] .ext4_mb_discard_lg_preallocations+0x394/0x444 [ 568.878025] [c0000001fa957340] [c0000000002fb45c] .ext4_mb_release_context+0x33c/0x734 [ 568.878032] [c0000001fa957440] [c0000000002fbcf8] .ext4_mb_new_blocks+0x4a4/0x5f4 [ 568.878039] [c0000001fa957510] [c0000000002ef56c] .ext4_ext_map_blocks+0xc28/0x1178 [ 568.878047] [c0000001fa957640] [c0000000002c1a94] .ext4_map_blocks+0x2c8/0x490 [ 568.878054] [c0000001fa957730] [c0000000002c536c] .ext4_writepages+0x738/0xc60 [ 568.878062] [c0000001fa957950] [c000000000168a78] .do_writepages+0x5c/0x80 [ 568.878069] [c0000001fa9579d0] [c00000000015d1c4] .__filemap_fdatawrite_range+0x88/0xb0 [ 568.878078] [c0000001fa957aa0] [c00000000015d23c] .filemap_write_and_wait_range+0x50/0xfc [ 568.878085] [c0000001fa957b30] [c0000000002b8edc] .ext4_sync_file+0x220/0x3c4 [ 568.878092] [c0000001fa957be0] [c0000000001f849c] .vfs_fsync_range+0x64/0x80 [ 568.878098] [c0000001fa957c70] [c0000000001f84f0] .vfs_fsync+0x38/0x4c [ 568.878105] [c0000001fa957d00] [c0000000001f87f4] .do_fsync+0x54/0x90 [ 568.878111] [c0000001fa957db0] [c0000000001f8894] .SyS_fsync+0x28/0x3c [ 568.878120] [c0000001fa957e30] [c000000000009c88] syscall_exit+0x0/0x7c [ 568.878125] Instruction dump: [ 568.878130] 60000000 813d0034 81610070 38000000 7f8b4800 419e001c 813f007c 7d2bfe70 [ 568.878144] 7d604a78 7c005850 54000ffe 7c0007b4 <0b000000> e8a10076 e87f0090 7fa4eb78 [ 568.878160] ---[ end trace 594d911d9654770b ]--- In addition fix the STD_GROUP optimization so that it works for bigalloc file systems as well. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Reported-by: Li Zhong <lizhongfs@gmail.com> Reviewed-by: Lukas Czerner <lczerner@redhat.com> Cc: stable@vger.kernel.org # 3.10		2013-07-05 23:11:16 -04:00
..
acl.c	ext4: fix the number of credits needed for acl ops with inline data	2013-02-09 15:23:03 -05:00
acl.h	fs: take the ACL checks to common code	2011-07-25 14:30:23 -04:00
balloc.c	ext4: fix ext4_get_group_number()	2013-07-05 23:11:16 -04:00
bitmap.c	ext4: Checksum the block bitmap properly with bigalloc enabled	2012-10-22 00:34:32 -04:00
block_validity.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
dir.c	ext4: fix readdir error in the case of inline_data+dir_index	2013-04-19 17:53:09 -04:00
ext4_extents.h	ext4: mext_insert_extents should update extent block checksum	2013-04-19 14:04:12 -04:00
ext4_jbd2.c	ext4: provide wrappers for transaction reservation calls	2013-06-04 12:37:50 -04:00
ext4_jbd2.h	ext4: use transaction reservation for extent conversion in ext4_end_io	2013-06-04 13:21:11 -04:00
ext4.h	ext4: pass inode pointer instead of file pointer to punch hole	2013-07-01 08:12:38 -04:00
extents_status.c	ext4: improve extent cache shrink mechanism to avoid to burn CPU time	2013-07-01 08:12:37 -04:00
extents_status.h	ext4: improve extent cache shrink mechanism to avoid to burn CPU time	2013-07-01 08:12:37 -04:00
extents.c	ext4: optimize starting extent in ext4_ext_rm_leaf()	2013-07-01 08:12:41 -04:00
file.c	ext4: fix overflows in SEEK_HOLE, SEEK_DATA implementations	2013-05-31 19:37:56 -04:00
fsync.c	ext4: Fix fsync error handling after filesystem abort	2013-06-12 22:38:04 -04:00
hash.c	ext4: reduce one "if" comparison in ext4_dirhash()	2013-02-01 22:33:21 -05:00
ialloc.c	ext4: provide wrappers for transaction reservation calls	2013-06-04 12:37:50 -04:00
indirect.c	ext4: translate flag bits to strings in tracepoints	2013-07-01 08:12:40 -04:00
inline.c	ext4: improve free space calculation for inline_data	2013-07-01 08:12:37 -04:00
inode.c	ext4: silence warning in ext4_writepages()	2013-07-05 21:57:22 -04:00
ioctl.c	ext4: fix usless declarations	2013-04-09 22:48:36 -04:00
Kconfig	ext4: fix Kconfig documentation for CONFIG_EXT4_DEBUG	2013-04-21 20:32:03 -04:00
Makefile	ext4: Remove CONFIG_EXT4_FS_XATTR	2012-12-10 16:30:43 -05:00
mballoc.c	ext4: implement error handling of ext4_mb_new_preallocation()	2013-07-01 08:12:36 -04:00
mballoc.h	ext4: use module parameters instead of debugfs for mballoc_debug	2013-02-09 16:28:20 -05:00
migrate.c	ext4: do not convert to indirect with bigalloc enabled	2013-04-11 10:54:46 -04:00
mmp.c	ext4: mark all metadata I/O with REQ_META	2013-04-20 15:46:17 -04:00
move_extent.c	ext4: delete unused variables	2013-06-17 08:56:26 -04:00
namei.c	ext3,ext4: don't mess with dir_file->f_pos in htree_dirblock_to_tree()	2013-07-01 08:12:38 -04:00
page-io.c	ext4: add check to io_submit_init_bio	2013-06-06 10:18:22 -04:00
resize.c	ext4: fix corruption when online resizing a fs with 1K block size	2013-07-01 08:12:08 -04:00
super.c	ext4: fix ext4_get_group_number()	2013-07-05 23:11:16 -04:00
symlink.c	ext4: Remove CONFIG_EXT4_FS_XATTR	2012-12-10 16:30:43 -05:00
truncate.h	ext4: move common truncate functions to header file	2011-06-27 19:16:04 -04:00
xattr_security.c	Merge branch 'for_linus' into for_linus_merged	2012-01-10 11:54:07 -05:00
xattr_trusted.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
xattr_user.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
xattr.c	ext4: fix miscellaneous big endian warnings	2013-04-09 23:59:55 -04:00
xattr.h	ext4: reserve xattr index for Rich ACL support	2013-04-18 14:53:15 -04:00