kernel_optimize_test/drivers/bcma
Geert Uytterhoeven a733311413 bcma: BCMA_DRIVER_GPIO should depend on GPIOLIB instead of selecting it
Commit cf0936b06d ("bcma: add GPIO driver")
added BCMA_DRIVER_GPIO, which unconditionally selects GPIOLIB, causing
a Kconfig warning:

warning: (ARCH_REQUIRE_GPIOLIB && SSB_DRIVER_GPIO && BCMA_DRIVER_GPIO && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)

and build failure for m68k/allmodconfig:

In file included from include/linux/bcma/bcma.h:8,
                 from drivers/bcma/bcma_private.h:9,
                 from drivers/bcma/main.c:9:
include/linux/bcma/bcma_driver_chipcommon.h:582: error: field ‘gpio’ has incomplete type
In file included from include/linux/bcma/bcma.h:12,
                 from drivers/bcma/bcma_private.h:9,
                 from drivers/bcma/main.c:9:
include/linux/ssb/ssb.h:440: error: field ‘gpio’ has incomplete type
make[4]: *** [drivers/bcma/main.o] Error 1
make[3]: *** [drivers/bcma/] Error 2

Turn the select into a dependency to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2013-01-02 14:38:22 -05:00
..
bcma_private.h Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus 2012-12-14 14:27:45 -08:00
core.c bcma: change delays to follow timers-howto guide 2012-09-28 13:54:02 -04:00
driver_chipcommon_nflash.c bcma: mark nflash if it is the boot flash 2012-10-19 15:52:37 -04:00
driver_chipcommon_pmu.c MTD pull for 3.8 2012-12-19 12:47:41 -08:00
driver_chipcommon_sflash.c bcma: add some more flash chips for serial flash 2012-10-19 15:52:39 -04:00
driver_chipcommon.c Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus 2012-12-14 14:27:45 -08:00
driver_gmac_cmn.c bcma: add trivial GBIT MAC COMMON driver 2012-07-12 15:27:18 -04:00
driver_gpio.c bcma: add GPIO driver 2012-11-21 21:55:52 +01:00
driver_mips.c bcma: mips: fix clearing device IRQ 2012-12-10 15:49:53 -05:00
driver_pci_host.c bcma: handle return value of pci_assign_resource 2012-11-30 13:38:13 -05:00
driver_pci.c bcma: change delays to follow timers-howto guide 2012-09-28 13:54:02 -04:00
host_pci.c bcma: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP 2012-10-29 15:19:31 -04:00
host_soc.c bcma: make some functions static 2012-08-10 15:26:52 -04:00
Kconfig bcma: BCMA_DRIVER_GPIO should depend on GPIOLIB instead of selecting it 2013-01-02 14:38:22 -05:00
main.c Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus 2012-12-14 14:27:45 -08:00
Makefile bcma: add GPIO driver 2012-11-21 21:55:52 +01:00
README
scan.c bcma: add missing iounmap on error path 2012-07-26 15:37:57 -04:00
scan.h bcma: fix typo - reading number of slave wrappers 2012-07-12 15:27:17 -04:00
sprom.c bcma: use fallback sprom if sprom on card was not valid 2012-10-19 15:52:53 -04:00
TODO

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.