Song Liu aa5de305c9 kernel/events/uprobes.c: only do FOLL_SPLIT_PMD for uprobe register ... Attaching uprobe to text section in THP splits the PMD mapped page table into PTE mapped entries. On uprobe detach, we would like to regroup PMD mapped page table entry to regain performance benefit of THP. However, the regroup is broken For perf_event based trace_uprobe. This is because perf_event based trace_uprobe calls uprobe_unregister twice on close: first in TRACE_REG_PERF_CLOSE, then in TRACE_REG_PERF_UNREGISTER. The second call will split the PMD mapped page table entry, which is not the desired behavior. Fix this by only use FOLL_SPLIT_PMD for uprobe register case. Add a WARN() to confirm uprobe unregister never work on huge pages, and abort the operation when this WARN() triggers. Link: http://lkml.kernel.org/r/20191017164223.2762148-6-songliubraving@fb.com Fixes: 5a52c9df62 ("uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT") Signed-off-by: Song Liu <songliubraving@fb.com> Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: William Kucharski <william.kucharski@oracle.com> Cc: Yang Shi <yang.shi@linux.alibaba.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2019-10-19 06:32:33 -04:00
..
callchain.c	perf/core: Convert to SPDX license identifiers	2019-02-04 08:46:11 +01:00
core.c	perf/core: Fix corner case in perf_rotate_context()	2019-10-09 12:44:13 +02:00
hw_breakpoint.c	perf/hw_breakpoint: Fix arch_hw_breakpoint use-before-initialization	2019-09-06 08:24:01 +02:00
internal.h	perf/ring-buffer: Use regular variables for nesting	2019-05-24 09:00:11 +02:00
Makefile
ring_buffer.c	perf/ring-buffer: Use regular variables for nesting	2019-05-24 09:00:11 +02:00
uprobes.c	kernel/events/uprobes.c: only do FOLL_SPLIT_PMD for uprobe register	2019-10-19 06:32:33 -04:00