forked from luck/tmp_suning_uos_patched
1d375b58c1
On some devices the contents of the ctrl register get lost over a suspend/resume and the PWM comes back up disabled after the resume. This is seen on some Bay Trail devices with the PWM in ACPI enumerated mode, so it shows up as a platform device instead of a PCI device. If we still think it is enabled and then try to change the duty-cycle after this, we end up with a "PWM_SW_UPDATE was not cleared" error and the PWM is stuck in that state from then on. This commit adds suspend and resume pm callbacks to the pwm-lpss-platform code, which save/restore the ctrl register over a suspend/resume, fixing this. Note that: 1) There is no need to do this over a runtime suspend, since we only runtime suspend when disabled and then we properly set the enable bit and reprogram the timings when we re-enable the PWM. 2) This may be happening on more systems then we realize, but has been covered up sofar by a bug in the acpi-lpss.c code which was save/restoring the regular device registers instead of the lpss private registers due to lpss_device_desc.prv_offset not being set. This is fixed by a later patch in this series. Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
35 lines
859 B
C
35 lines
859 B
C
/*
|
|
* Intel Low Power Subsystem PWM controller driver
|
|
*
|
|
* Copyright (C) 2014, Intel Corporation
|
|
*
|
|
* Derived from the original pwm-lpss.c
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#ifndef __PWM_LPSS_H
|
|
#define __PWM_LPSS_H
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/pwm.h>
|
|
|
|
struct pwm_lpss_chip;
|
|
|
|
struct pwm_lpss_boardinfo {
|
|
unsigned long clk_rate;
|
|
unsigned int npwm;
|
|
unsigned long base_unit_bits;
|
|
bool bypass;
|
|
};
|
|
|
|
struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,
|
|
const struct pwm_lpss_boardinfo *info);
|
|
int pwm_lpss_remove(struct pwm_lpss_chip *lpwm);
|
|
int pwm_lpss_suspend(struct device *dev);
|
|
int pwm_lpss_resume(struct device *dev);
|
|
|
|
#endif /* __PWM_LPSS_H */
|