Chuck Lever 65d269538a NFS: Too many GETATTR and ACCESS calls after direct I/O ... The cached read and write paths initialize fattr->time_start in their setup procedures. The value of fattr->time_start is propagated to read_cache_jiffies by nfs_update_inode(). Subsequent calls to nfs_attribute_timeout() will then use a good time stamp when computing the attribute cache timeout, and squelch unneeded GETATTR calls. Since the direct I/O paths erroneously leave the inode's fattr->time_start field set to zero, read_cache_jiffies for that inode is set to zero after any direct read or write operation. This triggers an otw GETATTR or ACCESS call to update the file's attribute and access caches properly, even when the NFS READ or WRITE replies have usable post-op attributes. Make sure the direct read and write setup code performs the same fattr initialization as the cached I/O paths to prevent unnecessary GETATTR calls. This was likely introduced by commit 0e574af1 in 2.6.15, which appears to add new nfs_fattr_init() call sites in the cached read and write paths, but not in the equivalent places in fs/nfs/direct.c. A subsequent commit in the same series, 33801147, introduces the fattr->time_start field. Interestingly, the direct write reschedule path already has a call to nfs_fattr_init() in the right place. Reported-by: Quentin Barnes <qbarnes@yahoo-inc.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Cc: stable@kernel.org Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2010-02-15 19:53:43 -08:00
..
cache_lib.c
cache_lib.h
callback_proc.c
callback_xdr.c
callback.c
callback.h
client.c
delegation.c
delegation.h
dir.c	nfs: fix oops in nfs_rename()	2010-01-06 18:48:26 -05:00
direct.c	NFS: Too many GETATTR and ACCESS calls after direct I/O	2010-02-15 19:53:43 -08:00
dns_resolve.c
dns_resolve.h
file.c	NFS: Try to commit unstable writes in nfs_release_page()	2010-01-26 15:41:53 -05:00
fscache-index.c
fscache.c	NFS: Fix a bug in nfs_fscache_release_page()	2010-02-09 14:29:10 -05:00
fscache.h
getroot.c
idmap.c
inode.c	NFS: Don't clobber the attribute type in nfs_update_inode()	2010-02-03 08:27:35 -05:00
internal.h
iostat.h
Kconfig
Makefile
mount_clnt.c	NFS: Fix the mapping of the NFSERR_SERVERFAULT error	2010-02-09 14:29:29 -05:00
namespace.c
nfs2xdr.c	NFS: Fix the mapping of the NFSERR_SERVERFAULT error	2010-02-09 14:29:29 -05:00
nfs3acl.c
nfs3proc.c
nfs3xdr.c
nfs4_fs.h	NFS: Ensure that we handle NFS4ERR_STALE_STATEID correctly	2010-01-26 15:42:47 -05:00
nfs4namespace.c
nfs4proc.c	NFS: Ensure that we handle NFS4ERR_STALE_STATEID correctly	2010-01-26 15:42:47 -05:00
nfs4renewd.c
nfs4state.c	NFS: Ensure that we handle NFS4ERR_STALE_STATEID correctly	2010-01-26 15:42:47 -05:00
nfs4xdr.c	NFS: Fix the mapping of the NFSERR_SERVERFAULT error	2010-02-09 14:29:29 -05:00
nfsroot.c
pagelist.c	NFS: Fix an Oops when truncating a file	2010-02-03 08:27:22 -05:00
proc.c
read.c
super.c	NFS: Fix a umount race	2010-02-03 08:27:35 -05:00
symlink.c
sysctl.c	NFS: Avoid warnings when CONFIG_NFS_V4=n	2010-01-26 15:42:11 -05:00
unlink.c
write.c	NFS: Remove a redundant check for PageFsCache in nfs_migrate_page()	2010-02-09 14:29:21 -05:00