Michael Kelley d0ff14fdc9 genirq: Properly pair kobject_del() with kobject_add() ... If alloc_descs() fails before irq_sysfs_init() has run, free_desc() in the cleanup path will call kobject_del() even though the kobject has not been added with kobject_add(). Fix this by making the call to kobject_del() conditional on whether irq_sysfs_init() has run. This problem surfaced because commit aa30f47cf6 ("kobject: Add support for default attribute groups to kobj_type") makes kobject_del() stricter about pairing with kobject_add(). If the pairing is incorrrect, a WARNING and backtrace occur in sysfs_remove_group() because there is no parent. [ tglx: Add a comment to the code and make it work with CONFIG_SYSFS=n ] Fixes: ecb3f394c5 ("genirq: Expose interrupt information through sysfs") Signed-off-by: Michael Kelley <mikelley@microsoft.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/1564703564-4116-1-git-send-email-mikelley@microsoft.com		2019-08-19 21:41:19 +02:00
..
affinity.c	genirq/affinity: Create affinity mask for single vector	2019-08-08 08:47:55 +02:00
autoprobe.c	genirq: Delay deactivation in free_irq()	2019-07-03 10:12:28 +02:00
chip.c	Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:22:57 -07:00
cpuhotplug.c	genirq: Delay deactivation in free_irq()	2019-07-03 10:12:28 +02:00
debug.h
debugfs.c	treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively	2019-04-09 14:19:06 +02:00
devres.c	genirq/devres: Use struct_size() in devm_kzalloc()	2019-04-16 21:54:03 +02:00
dummychip.c
generic-chip.c
handle.c	treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively	2019-04-09 14:19:06 +02:00
internals.h	Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:22:57 -07:00
ipi.c
irq_sim.c
irqdesc.c	genirq: Properly pair kobject_del() with kobject_add()	2019-08-19 21:41:19 +02:00
irqdomain.c	irq/irqdomain: Fix comment typo	2019-07-06 10:40:20 +02:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	genirq/timings: Add selftest for circular array	2019-06-12 10:47:04 +02:00
manage.c	Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:22:57 -07:00
matrix.c
migration.c
msi.c
pm.c
proc.c
resend.c
settings.h
spurious.c	treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively	2019-04-09 14:19:06 +02:00
timings.c	genirq/timings: Add selftest for next event computation	2019-06-12 10:47:05 +02:00