Rabin Vincent 086ba77a6d tracing/syscalls: Ignore numbers outside NR_syscalls' range ... ARM has some private syscalls (for example, set_tls(2)) which lie outside the range of NR_syscalls. If any of these are called while syscall tracing is being performed, out-of-bounds array access will occur in the ftrace and perf sys_{enter,exit} handlers. # trace-cmd record -e raw_syscalls:* true && trace-cmd report ... true-653 [000] 384.675777: sys_enter: NR 192 (0, 1000, 3, 4000022, ffffffff, 0) true-653 [000] 384.675812: sys_exit: NR 192 = 1995915264 true-653 [000] 384.675971: sys_enter: NR 983045 (76f74480, 76f74000, 76f74b28, 76f74480, 76f76f74, 1) true-653 [000] 384.675988: sys_exit: NR 983045 = 0 ... # trace-cmd record -e syscalls:* true [ 17.289329] Unable to handle kernel paging request at virtual address aaaaaace [ 17.289590] pgd = 9e71c000 [ 17.289696] [aaaaaace] *pgd=00000000 [ 17.289985] Internal error: Oops: 5 [#1] PREEMPT SMP ARM [ 17.290169] Modules linked in: [ 17.290391] CPU: 0 PID: 704 Comm: true Not tainted 3.18.0-rc2+ #21 [ 17.290585] task: 9f4dab00 ti: 9e710000 task.ti: 9e710000 [ 17.290747] PC is at ftrace_syscall_enter+0x48/0x1f8 [ 17.290866] LR is at syscall_trace_enter+0x124/0x184 Fix this by ignoring out-of-NR_syscalls-bounds syscall numbers. Commit cd0980fc8a "tracing: Check invalid syscall nr while tracing syscalls" added the check for less than zero, but it should have also checked for greater than NR_syscalls. Link: http://lkml.kernel.org/p/1414620418-29472-1-git-send-email-rabin@rab.in Fixes: cd0980fc8a "tracing: Check invalid syscall nr while tracing syscalls" Cc: stable@vger.kernel.org # 2.6.33+ Signed-off-by: Rabin Vincent <rabin@rab.in> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>		2014-10-30 20:58:38 -04:00
..
blktrace.c
ftrace.c	ftrace: Fix checking of trampoline ftrace_ops in finding trampoline	2014-10-24 16:53:11 -04:00
Kconfig
Makefile
power-traces.c
ring_buffer_benchmark.c	sched, cleanup, treewide: Remove set_current_state(TASK_RUNNING) after schedule()	2014-09-19 12:35:17 +02:00
ring_buffer.c	ring-buffer: Fix infinite spin in reading buffer	2014-10-02 16:51:18 -04:00
rpm-traces.c
trace_benchmark.c
trace_benchmark.h
trace_branch.c
trace_clock.c
trace_entries.h
trace_event_perf.c	perf: Check permission only for parent tracepoint event	2014-07-28 10:01:38 +02:00
trace_events_filter_test.h
trace_events_filter.c
trace_events_trigger.c
trace_events.c	tracing: Robustify wait loop	2014-10-08 19:51:01 -04:00
trace_export.c
trace_functions_graph.c
trace_functions.c
trace_irqsoff.c
trace_kdb.c
trace_kprobe.c
trace_mmiotrace.c
trace_nop.c
trace_output.c
trace_output.h
trace_printk.c
trace_probe.c
trace_probe.h
trace_sched_switch.c
trace_sched_wakeup.c
trace_selftest_dynamic.c
trace_selftest.c	Seems that Peter Zijlstra added a new check that is making old	2014-10-12 07:28:55 -04:00
trace_seq.c
trace_stack.c	sched: Add helper for task stack page overrun checking	2014-09-19 12:35:23 +02:00
trace_stat.c
trace_stat.h
trace_syscalls.c	tracing/syscalls: Ignore numbers outside NR_syscalls' range	2014-10-30 20:58:38 -04:00
trace_uprobe.c
trace.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-08-05 17:46:42 -07:00
trace.h