Linus Torvalds b212921b13 elf: don't use MAP_FIXED_NOREPLACE for elf executable mappings ... In commit 4ed2863951 ("fs, elf: drop MAP_FIXED usage from elf_map") we changed elf to use MAP_FIXED_NOREPLACE instead of MAP_FIXED for the executable mappings. Then, people reported that it broke some binaries that had overlapping segments from the same file, and commit ad55eac74f ("elf: enforce MAP_FIXED on overlaying elf segments") re-instated MAP_FIXED for some overlaying elf segment cases. But only some - despite the summary line of that commit, it only did it when it also does a temporary brk vma for one obvious overlapping case. Now Russell King reports another overlapping case with old 32-bit x86 binaries, which doesn't trigger that limited case. End result: we had better just drop MAP_FIXED_NOREPLACE entirely, and go back to MAP_FIXED. Yes, it's a sign of old binaries generated with old tool-chains, but we do pride ourselves on not breaking existing setups. This still leaves MAP_FIXED_NOREPLACE in place for the load_elf_interp() and the old load_elf_library() use-cases, because nobody has reported breakage for those. Yet. Note that in all the cases seen so far, the overlapping elf sections seem to be just re-mapping of the same executable with different section attributes. We could possibly introduce a new MAP_FIXED_NOFILECHANGE flag or similar, which acts like NOREPLACE, but allows just remapping the same executable file using different protection flags. It's not clear that would make a huge difference to anything, but if people really hate that "elf remaps over previous maps" behavior, maybe at least a more limited form of remapping would alleviate some concerns. Alternatively, we should take a look at our elf_map() logic to see if we end up not mapping things properly the first time. In the meantime, this is the minimal "don't do that then" patch while people hopefully think about it more. Reported-by: Russell King <linux@armlinux.org.uk> Fixes: 4ed2863951 ("fs, elf: drop MAP_FIXED usage from elf_map") Fixes: ad55eac74f ("elf: enforce MAP_FIXED on overlaying elf segments") Cc: Michal Hocko <mhocko@suse.com> Cc: Kees Cook <keescook@chromium.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2019-10-06 13:53:27 -07:00
..
9p	9p pull request for inclusion in 5.4	2019-09-27 15:10:34 -07:00
adfs
affs
afs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-09-29 19:42:07 -07:00
autofs
befs
bfs
btrfs	for-5.4-rc1-tag	2019-09-30 10:25:24 -07:00
cachefiles
ceph
cifs	9 smb3 patches including an important patch for debugging traces with wireshark, and 3 patches for stable	2019-09-29 19:37:32 -07:00
coda
configfs
cramfs
crypto
debugfs	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
devpts
dlm
ecryptfs
efivarfs
efs
erofs	erofs: fix mis-inplace determination related with noio chain	2019-10-01 04:54:45 +08:00
exportfs
ext2
ext4	Merge branch 'entropy'	2019-09-29 19:25:39 -07:00
f2fs
fat
freevxfs
fscache
fuse	add virtio-fs	2019-09-27 15:54:24 -07:00
gfs2
hfs
hfsplus
hostfs
hpfs
hugetlbfs
iomap
isofs
jbd2
jffs2
jfs
kernfs
lockd
minix
nfs
nfs_common
nfsd	Highlights:	2019-09-27 17:00:27 -07:00
nilfs2
nls
notify	Highlights:	2019-09-27 17:00:27 -07:00
ntfs
ocfs2
omfs
openpromfs
orangefs
overlayfs
proc	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
pstore
qnx4
qnx6
quota
ramfs
reiserfs
romfs
squashfs
sysfs
sysv
tracefs	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
ubifs
udf
ufs
unicode
verity
xfs
aio.c
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	elf: don't use MAP_FIXED_NOREPLACE for elf executable mappings	2019-10-06 13:53:27 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c
block_dev.c
buffer.c
char_dev.c
compat_binfmt_elf.c
compat_ioctl.c
compat.c
coredump.c
d_path.c
dax.c
dcache.c
dcookies.c
direct-io.c
drop_caches.c
eventfd.c
eventpoll.c
exec.c
fcntl.c
fhandle.c
file_table.c
file.c
filesystems.c
fs_context.c
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c
fsopen.c
inode.c
internal.h
io_uring.c	for-linus-2019-10-03	2019-10-04 09:56:51 -07:00
ioctl.c
Kconfig
Kconfig.binfmt
libfs.c
locks.c	Highlights:	2019-09-27 17:00:27 -07:00
Makefile
mbcache.c
mount.h
mpage.c
namei.c
namespace.c
no-block.c
nsfs.c
open.c
pipe.c
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c
readdir.c	Make filldir[64]() verify the directory entry filename is valid	2019-10-05 12:00:36 -07:00
select.c
seq_file.c
signalfd.c
splice.c
stack.c
stat.c
statfs.c	vfs: Fix EOVERFLOW testing in put_compat_statfs64	2019-10-03 14:21:35 -07:00
super.c
sync.c
timerfd.c
userfaultfd.c
utimes.c
xattr.c