forked from luck/tmp_suning_uos_patched
dcd9637961
In both the read and write cases it will return an error if copy_{from/to}_user faults. However, I let the driver try to read/write as much as it can just as it normally would , then finally it returns an error if there was one. This was the most straight forward way to handle the error , since there isn't a clear way to clean up the buffers on error . I moved retval in idetape_chrdev_write() down into the actual code blocks since it's really once used there, and it conflicted with my ret variable. Fixes the following warning, drivers/ide/ide-tape.c: In function âidetape_copy_stage_from_userâ: drivers/ide/ide-tape.c:2662: warning: ignoring return value of âcopy_from_userâ, declared with attribute warn_unused_result drivers/ide/ide-tape.c: In function âidetape_copy_stage_to_userâ: drivers/ide/ide-tape.c:2689: warning: ignoring return value of âcopy_to_userâ, declared with attribute warn_unused_result Signed-off-by: Daniel Walker <dwalker@mvista.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> |
||
---|---|---|
.. | ||
arm | ||
cris | ||
h8300 | ||
legacy | ||
mips | ||
pci | ||
ppc | ||
ide-cd.c | ||
ide-cd.h | ||
ide-disk.c | ||
ide-dma.c | ||
ide-floppy.c | ||
ide-generic.c | ||
ide-io.c | ||
ide-iops.c | ||
ide-lib.c | ||
ide-pnp.c | ||
ide-probe.c | ||
ide-proc.c | ||
ide-tape.c | ||
ide-taskfile.c | ||
ide-timing.h | ||
ide.c | ||
Kconfig | ||
Makefile | ||
setup-pci.c |