From cff229d9fa2994851d17a9cec512de00421fbecc Mon Sep 17 00:00:00 2001 From: Kurtis Rader Date: Wed, 22 Jul 2020 21:21:33 -0700 Subject: [PATCH] Remove two obsolete TODO comments and resolve one --- pkg/eval/builtin_fn_io.go | 4 ---- pkg/eval/builtin_fn_num.go | 13 ++++++++++++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/pkg/eval/builtin_fn_io.go b/pkg/eval/builtin_fn_io.go index 2469e42b..75a5744c 100644 --- a/pkg/eval/builtin_fn_io.go +++ b/pkg/eval/builtin_fn_io.go @@ -198,8 +198,6 @@ import ( // Etymology: Perl, as // [`File::Slurp`](http://search.cpan.org/~uri/File-Slurp-9999.19/lib/File/Slurp.pm). -// TODO(xiaq): Document from-lines. - //elvdoc:fn from-json // // ```elvish @@ -233,8 +231,6 @@ import ( // // @cf to-json -// TODO(xiaq): Document to-lines. - //elvdoc:fn to-json // // ```elvish diff --git a/pkg/eval/builtin_fn_num.go b/pkg/eval/builtin_fn_num.go index 2df23335..e36fa354 100644 --- a/pkg/eval/builtin_fn_num.go +++ b/pkg/eval/builtin_fn_num.go @@ -9,7 +9,18 @@ import ( // Numerical operations. -// TODO(xiaq): Document float64. +//elvdoc:fn float64 +// +// ```elvish +// float64 123 +// float64 NaN +// float64 Inf +// ``` +// +// Explicitly convert a string to a `float64` data type. +// +// It is very rare that this command is needed. See the discussion of the +// [number](language.html#number) data type. //elvdoc:fn + - * / //