Meng Li 7e867f8bb3 soc: fsl: dpio: use the combined functions to protect critical zone ... commit dc7e5940aad6641bd5ab33ea8b21c4b3904d989f upstream. In orininal code, use 2 function spin_lock() and local_irq_save() to protect the critical zone. But when enable the kernel debug config, there are below inconsistent lock state detected. ================================ WARNING: inconsistent lock state 5.10.63-yocto-standard #1 Not tainted -------------------------------- inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. lock_torture_wr/226 [HC0[0]:SC1[5]:HE1:SE0] takes: ffff002005b2dd80 (&p->access_spinlock){+.?.}-{3:3}, at: qbman_swp_enqueue_multiple_mem_back+0x44/0x270 {SOFTIRQ-ON-W} state was registered at: lock_acquire.part.0+0xf8/0x250 lock_acquire+0x68/0x84 _raw_spin_lock+0x68/0x90 qbman_swp_enqueue_multiple_mem_back+0x44/0x270 ...... cryptomgr_test+0x38/0x60 kthread+0x158/0x164 ret_from_fork+0x10/0x38 irq event stamp: 4498 hardirqs last enabled at (4498): [<ffff800010fcf980>] _raw_spin_unlock_irqrestore+0x90/0xb0 hardirqs last disabled at (4497): [<ffff800010fcffc4>] _raw_spin_lock_irqsave+0xd4/0xe0 softirqs last enabled at (4458): [<ffff8000100108c4>] __do_softirq+0x674/0x724 softirqs last disabled at (4465): [<ffff80001005b2a4>] __irq_exit_rcu+0x190/0x19c other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&p->access_spinlock); <Interrupt> lock(&p->access_spinlock); *** DEADLOCK *** So, in order to avoid deadlock, use the combined functions spin_lock_irqsave/spin_unlock_irqrestore() to protect critical zone. Fixes: 3b2abda7d2 ("soc: fsl: dpio: Replace QMAN array mode with ring mode enqueue") Cc: stable@vger.kernel.org Signed-off-by: Meng Li <Meng.Li@windriver.com> Signed-off-by: Li Yang <leoyang.li@nxp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-11-18 14:03:48 +01:00
..
actions
amlogic
aspeed	soc: aspeed: p2a-ctrl: Fix boundary check for mmap	2021-09-18 13:40:08 +02:00
atmel
bcm
dove
fsl	soc: fsl: dpio: use the combined functions to protect critical zone	2021-11-18 14:03:48 +01:00
gemini
imx	ARM: imx: fix imx8m dependencies	2021-02-03 23:28:45 +01:00
ixp4xx	soc: ixp4xx/qmgr: fix invalid __iomem access	2021-08-12 13:22:18 +02:00
kendryte
lantiq
mediatek	soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h	2021-08-26 08:35:42 -04:00
qcom	soc: qcom: mdt_loader: Drop PT_LOAD check on hash segment	2021-10-13 10:04:25 +02:00
renesas
rockchip	soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally	2021-09-15 09:50:31 +02:00
samsung	soc: samsung: exynos-asv: handle reading revision register error	2021-03-04 11:38:32 +01:00
sifive
sunxi
tegra	soc/tegra: fuse: Fix Tegra234-only builds	2021-07-25 14:36:15 +02:00
ti	soc: ti: omap-prm: Fix external abort for am335x pruss	2021-10-13 10:04:26 +02:00
ux500
versatile
xilinx
zte
Kconfig
Makefile