Mark Rutland 92347cfd62 KEYS: fix refcount_inc() on zero ... If a key's refcount is dropped to zero between key_lookup() peeking at the refcount and subsequently attempting to increment it, refcount_inc() will see a zero refcount. Here, refcount_inc() will WARN_ONCE(), and will *not* increment the refcount, which will remain zero. Once key_lookup() drops key_serial_lock, it is possible for the key to be freed behind our back. This patch uses refcount_inc_not_zero() to perform the peek and increment atomically. Fixes: fff292914d ("security, keys: convert key.usage from atomic_t to refcount_t") Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: David Howells <dhowells@redhat.com> Cc: David Windsor <dwindsor@gmail.com> Cc: Elena Reshetova <elena.reshetova@intel.com> Cc: Hans Liljestrand <ishkamiel@gmail.com> Cc: James Morris <james.l.morris@oracle.com> Cc: Kees Cook <keescook@chromium.org> Cc: Peter Zijlstra <peterz@infradead.org> Signed-off-by: James Morris <james.l.morris@oracle.com>		2017-06-09 13:29:50 +10:00
..
encrypted-keys	KEYS: encrypted: sanitize all key material	2017-06-09 13:29:48 +10:00
big_key.c
compat_dh.c
compat.c
dh.c	KEYS: Convert KEYCTL_DH_COMPUTE to use the crypto KPP API	2017-06-09 13:29:50 +10:00
gc.c	KEYS: sanitize key structs before freeing	2017-06-09 13:29:48 +10:00
internal.h
Kconfig	KEYS: Convert KEYCTL_DH_COMPUTE to use the crypto KPP API	2017-06-09 13:29:50 +10:00
key.c	KEYS: fix refcount_inc() on zero	2017-06-09 13:29:50 +10:00
keyctl.c	KEYS: sanitize add_key() and keyctl() key payloads	2017-06-09 13:29:48 +10:00
keyring.c
Makefile
permission.c
persistent.c
proc.c
process_keys.c	KEYS: put keyring if install_session_keyring_to_cred() fails	2017-06-09 13:29:46 +10:00
request_key_auth.c
request_key.c
sysctl.c
trusted.c	KEYS: trusted: sanitize all key material	2017-06-09 13:29:48 +10:00
trusted.h
user_defined.c	KEYS: user_defined: sanitize key payloads	2017-06-09 13:29:48 +10:00